Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/e2e: drop host-usr-src mount #1003

Merged
merged 1 commit into from
Dec 19, 2022

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Dec 15, 2022

Allows running e2e-tests in some more restricted environments.

Allows running e2e-tests in some more restricted environments.
@netlify
Copy link

netlify bot commented Dec 15, 2022

Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit fd0b812
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/639b341456cd40000817d700
😎 Deploy Preview https://deploy-preview-1003--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 15, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2022
@marquiz
Copy link
Contributor Author

marquiz commented Dec 15, 2022

/assign @ArangoGutierrez

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 15, 2022
@marquiz
Copy link
Contributor Author

marquiz commented Dec 16, 2022

/assign @fmuyassarov

@marquiz
Copy link
Contributor Author

marquiz commented Dec 16, 2022

I needed this for a v1.25 minikube cluster

@fmuyassarov
Copy link
Member

hmm., I've had a successful run though on minikube with 1.25 k8s cluster...
e2e results

Ran 7 of 251 Specs in 162.396 seconds
SUCCESS! -- 7 Passed | 0 Failed | 0 Pending | 244 Skipped
--- PASS: TestE2E (162.40s)
PASS
ok  	sigs.k8s.io/node-feature-discovery/test/e2e	162.445s

minikube version

$ minikube version
minikube version: v1.28.0
commit: 986b1ebd987211ed16f8cc10aed7d2c42fc8392f

k8s version

kubectl version
WARNING: This version information is deprecated and will be replaced with the output from kubectl version --short.  Use --output=yaml|json to get the full version.
Client Version: version.Info{Major:"1", Minor:"25", GitVersion:"v1.25.2", GitCommit:"5835544ca568b757a8ecae5c153f317e5736700e", GitTreeState:"clean", BuildDate:"2022-09-21T14:33:49Z", GoVersion:"go1.19.1", Compiler:"gc", Platform:"linux/amd64"}
Kustomize Version: v4.5.7
Server Version: version.Info{Major:"1", Minor:"25", GitVersion:"v1.25.3", GitCommit:"434bfd82814af038ad94d62ebe59b133fcb50506", GitTreeState:"clean", BuildDate:"2022-10-12T10:49:09Z", GoVersion:"go1.19.2", Compiler:"gc", Platform:"linux/amd64"}

@marquiz
Copy link
Contributor Author

marquiz commented Dec 19, 2022

hmm., I've had a successful run though on minikube with 1.25 k8s cluster...

I used kvm2 driver. And docker as the runtime (🫤) because of corporate https(s) proxy causes problems in minikube with containerd and cri-o

@marquiz
Copy link
Contributor Author

marquiz commented Dec 19, 2022

Could be also fixed in the particular case (with rw host root fs) with hostPath volume type HostPathDirectoryOrCreate but I'm not that fond of this solution as it mangles the host system directories, would file on ro filesystems and we shouldn't really need /usr/src for the e2e-tests (just a small gap in kconfig detection)

@fmuyassarov
Copy link
Member

hmm., I've had a successful run though on minikube with 1.25 k8s cluster...

I used kvm2 driver. And docker as the runtime (🫤) because of corporate https(s) proxy causes problems in minikube with containerd and cri-o

tested on kvm2 driver and I could reproduce the issue + dropping host-user-src fixed the issue. I think this patch doesn't have any harm to the docker driver in minikube and instead fixes the possible ways of running E2E on minikube clusters. As such, I'm +1
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 19, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7da0a2eb35e5ef1f269e7befa3e8439fcadeca82

@marquiz
Copy link
Contributor Author

marquiz commented Dec 19, 2022

/retest

@k8s-ci-robot k8s-ci-robot merged commit 4635b99 into kubernetes-sigs:master Dec 19, 2022
@marquiz marquiz deleted the devel/e2e-host-usr-src branch December 19, 2022 11:28
@marquiz marquiz mentioned this pull request Dec 20, 2022
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants