feat: add master resync period configurability

[AhmedGrati]

Resolves #1124.

[netlify]

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name	Link
🔨 Latest commit	7917434
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/64465170d2758d0008a64b5a
😎 Deploy Preview	https://deploy-preview-1139--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[AhmedGrati]

/cc @marquiz

[AhmedGrati]

yo guys @marquiz @PiotrProkop, I just found out that the sigs.k8s.io/yaml package cannot unmarshal time.Duration. You can test this example here:

package main

import (
	"fmt"
	"time"

	"sigs.k8s.io/yaml"
)

type Config struct {
	Timeout time.Duration `yaml:"timeout"`
}

func main() {
	var cfg Config

	b := []byte(`timeout: 60s`)
	yaml.Unmarshal(b, &cfg)
	fmt.Printf("timeout: %dm", int(cfg.Timeout.Minutes()))
}

Please correct me if I'm missing something.
As an alternative, we can go with using integers to indicate the number of hours, or maybe changing the package that we are using to gopkg.in/yaml.v3, which actually unmarshal the time.Duration type.
Curious to hear your thoughts.

[marquiz]

just found out that the sigs.k8s.io/yaml package cannot unmarshal time.Duration

Ah, yes. In NFD we have duration type in pkg/nfd-worker that does unmarhalling. So I'd suggest we just move that to pkg/utils/flags.go and use it from there, for now

As an alternative, we can go with using integers to indicate the number of hours, or maybe changing the package that we are using to gopkg.in/yaml.v3, which actually unmarshal the time.Duration type.

Hmm, interesting. We could do this, but do it carefully in a separate PR. I.e. understand the differences between the two libraries and what might break

[AhmedGrati]

/cc @marquiz

[AhmedGrati]

/retest

[marquiz]

Thanks @AhmedGrati for the update! A few small comments below

[marquiz]

Two tiny nits but after that I think I'm good 😊

[marquiz]

/assign @PiotrProkop

[PiotrProkop]

Looks good to me, If you can apply @marquiz suggestions I'll LGTM 😄 Good job!

[marquiz]

Nice addition to NFD @AhmedGrati, big thanks for working on this. I don't have anything to add 😎

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AhmedGrati, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[PiotrProkop]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 38d80cf31bfe2723a8d410cf48a10810b2179b69