-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: introduce a commong klog handling for cmd/nfd-* #1341
chore: introduce a commong klog handling for cmd/nfd-* #1341
Conversation
✅ Deploy Preview for kubernetes-sigs-nfd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
We are in the middle of a release cut, will review once V0.14 is out |
8b7f63d
to
b493506
Compare
@ArangoGutierrez Much appreciated! Also, I've seen that we could externalize handling klog its configuration changes in the config file to |
8736be7
to
aa2cbbf
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AhmedGrati for the PR. Looks pretty clean to me. One comment/question below to think about
aa2cbbf
to
6c761b3
Compare
Signed-off-by: AhmedGrati <ahmedgrati1999@gmail.com>
6c761b3
to
7ab6314
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1341 +/- ##
==========================================
+ Coverage 29.57% 29.96% +0.39%
==========================================
Files 56 56
Lines 7638 7475 -163
==========================================
- Hits 2259 2240 -19
+ Misses 5128 4987 -141
+ Partials 251 248 -3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job @AhmedGrati
/assign @ArangoGutierrez
Thanks for the review @marquiz @ArangoGutierrez. |
/hold cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 6ff8187ef32ed638f80e84713d0ab6912f665fcd
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AhmedGrati, ArangoGutierrez, marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Resolves #1339.