Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: introduce a commong klog handling for cmd/nfd-* #1341

Merged

Conversation

AhmedGrati
Copy link

Resolves #1339.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 7, 2023
@netlify
Copy link

netlify bot commented Sep 7, 2023

Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit 7ab6314
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/64fa42d01de6780008ac2fed
😎 Deploy Preview https://deploy-preview-1341--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 7, 2023
@AhmedGrati
Copy link
Author

/cc @ArangoGutierrez @marquiz

@ArangoGutierrez
Copy link
Contributor

We are in the middle of a release cut, will review once V0.14 is out
Thanks @AhmedGrati for your awesome contribution!
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 7, 2023
@AhmedGrati
Copy link
Author

@ArangoGutierrez Much appreciated! Also, I've seen that we could externalize handling klog its configuration changes in the config file to pkg/utils/klog. wdyt?

@AhmedGrati AhmedGrati force-pushed the chore-common-klog-handling branch 2 times, most recently from 8736be7 to aa2cbbf Compare September 7, 2023 11:24
@AhmedGrati
Copy link
Author

/retest

pkg/utils/klog/klog.go Outdated Show resolved Hide resolved
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AhmedGrati for the PR. Looks pretty clean to me. One comment/question below to think about

Signed-off-by: AhmedGrati <ahmedgrati1999@gmail.com>
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #1341 (7ab6314) into master (2e6a202) will increase coverage by 0.39%.
Report is 4 commits behind head on master.
The diff coverage is 21.62%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1341      +/-   ##
==========================================
+ Coverage   29.57%   29.96%   +0.39%     
==========================================
  Files          56       56              
  Lines        7638     7475     -163     
==========================================
- Hits         2259     2240      -19     
+ Misses       5128     4987     -141     
+ Partials      251      248       -3     
Files Changed Coverage Δ
pkg/nfd-master/nfd-master.go 45.45% <0.00%> (+0.45%) ⬆️
pkg/utils/klog/klog.go 18.75% <18.75%> (ø)
pkg/nfd-worker/nfd-worker.go 58.16% <33.33%> (+1.24%) ⬆️
cmd/nfd-worker/main.go 58.33% <100.00%> (-5.67%) ⬇️

... and 1 file with indirect coverage changes

📢 Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubernetes-sigs).

Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @AhmedGrati
/assign @ArangoGutierrez

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2023
@AhmedGrati
Copy link
Author

Thanks for the review @marquiz @ArangoGutierrez.

@ArangoGutierrez
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 8, 2023
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 8, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6ff8187ef32ed638f80e84713d0ab6912f665fcd

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AhmedGrati, ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ArangoGutierrez,marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a2083f8 into kubernetes-sigs:master Sep 8, 2023
13 checks passed
@marquiz marquiz mentioned this pull request Dec 20, 2023
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Common library functions klog config file option handling
5 participants