Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source/local: simplify feature file size checking #1351

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Sep 8, 2023

No description provided.

@netlify
Copy link

netlify bot commented Sep 8, 2023

Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit a5e78f0
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/64fb0e4baae3a300081efd59
😎 Deploy Preview https://deploy-preview-1351--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 8, 2023
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2023
@marquiz
Copy link
Contributor Author

marquiz commented Sep 8, 2023

/assign @ArangoGutierrez
/cc @AhmedGrati

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 8, 2023
Copy link

@AhmedGrati AhmedGrati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's much better 😁 Thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AhmedGrati, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jjacobelli
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 8, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4526f650e15920a707d3341cbd9f4b80966d7f82

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #1351 (a5e78f0) into master (a2083f8) will decrease coverage by 0.03%.
Report is 2 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1351      +/-   ##
==========================================
- Coverage   29.96%   29.94%   -0.03%     
==========================================
  Files          56       56              
  Lines        7475     7518      +43     
==========================================
+ Hits         2240     2251      +11     
- Misses       4987     5014      +27     
- Partials      248      253       +5     
Files Changed Coverage Δ
source/local/local.go 45.53% <100.00%> (+0.24%) ⬆️

... and 1 file with indirect coverage changes

📢 Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubernetes-sigs).

@k8s-ci-robot k8s-ci-robot merged commit b7aa0b2 into kubernetes-sigs:master Sep 8, 2023
13 checks passed
@marquiz marquiz deleted the devel/local-refactor branch September 8, 2023 15:40
@marquiz marquiz mentioned this pull request Dec 20, 2023
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants