feat: ignore hidden feature files

[AhmedGrati]

Resolves #1337.

[netlify]

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name	Link
🔨 Latest commit	6c895b4
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/64ff201bbb5a070008f90672
😎 Deploy Preview	https://deploy-preview-1353--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[AhmedGrati]

/cc @ArangoGutierrez @marquiz
ping @eero-t @tkatila.

[eero-t]

Please describe in docs also why hidden files should be used. This should preferably be in the same place as where NFD docs say that feature files should be updated atomically (as this change allows NFD client to write features to a dot file, and then atomically rename it to real feature file name).

[eero-t]

/lgtm

[k8s-ci-robot]

@eero-t: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[AhmedGrati]

Thanks for the review @eero-t! ping @marquiz.

[AhmedGrati]

/retest

[marquiz]

Looking at the docs, we now promise that dot-files are ignored for both feature files and hooks. That's probably a good idea (even if hooks are deprecated), see my comments below

[eero-t]

Looking at the docs, we now promise that dot-files are ignored for both feature files and hooks. That's probably a good idea (even if hooks are deprecated)

In the hook binary case, I would assume them to be moved to hook dir from somewhere else (e.g. installation container), which is atomic (at least as long as it's on the same file system) => IMHO dot file handling is not not really needed for hooks, but either updating doc again, or adding that feature also to hooks should both be fine.

[AhmedGrati]

I added the same check to hooks also.

[eero-t]

Test for checking that normally named feature file is parsed, but one prefixed with dot is not, would also be good. This could be part of some other feature file test though, it does not necessarily need its own.

EDIT: ignore, I'm blind.

[marquiz]

Test for checking that normally named feature file is parsed, but one prefixed with dot is not, would also be good. This could be part of some other feature file test though, it does not necessarily need its own.

But that is there already, afaiu

[marquiz]

Thanks @AhmedGrati, looks good to me now
/assign @ArangoGutierrez

[AhmedGrati]

ping @ArangoGutierrez

[ArangoGutierrez]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 4621371e0a4137eb69bc3d7f2b93fe9968a0b4a7

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AhmedGrati, ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ArangoGutierrez,marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

Merging #1353 (6c895b4) into master (b7aa0b2) will decrease coverage by 0.02%.
Report is 6 commits behind head on master.
The diff coverage is 50.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1353      +/-   ##
==========================================
- Coverage   30.03%   30.02%   -0.02%     
==========================================
  Files          56       56              
  Lines        7451     7457       +6     
==========================================
+ Hits         2238     2239       +1     
- Misses       4968     4974       +6     
+ Partials      245      244       -1     

Files Changed	Coverage Δ
source/local/local.go	45.66% <50.00%> (+0.12%)	⬆️

... and 1 file with indirect coverage changes