Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts/update-gh-pages: sync OWNERS from master to gh-pages #1355

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Sep 11, 2023

The gh-pages branch is normally automatically managed by the GitHub workflow. However, on really rare occasions there may beed to contribute something manually via a PR. Thus, this patch updates the update-gh-pages script to sync the OWNERS from master the gh-pages branch branch, to enable the usual prow-based workflow for PRs in gh-pages branch.

The gh-pages branch is normally automatically managed by the GitHub
workflow. However, on really rare occasions there may beed to contribute
something manually via a PR. Thus, this patch updates the
update-gh-pages script to sync the OWNERS from master the gh-pages
branch branch, to enable the usual prow-based workflow for PRs in
gh-pages branch.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 11, 2023
@netlify
Copy link

netlify bot commented Sep 11, 2023

Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit f5084cb
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/64ff14ffce2ed10008a8acfa
😎 Deploy Preview https://deploy-preview-1355--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 11, 2023
@marquiz
Copy link
Contributor Author

marquiz commented Sep 11, 2023

Supersedes #1354 that prow wanted to close and I wasn't able to repurpose...

/assign @ArangoGutierrez

Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 11, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ArangoGutierrez,marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 176631290e7a5e4a7e41aa5ab06d5f3a1dbb4ae1

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #1355 (f5084cb) into master (b7aa0b2) will decrease coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1355      +/-   ##
==========================================
- Coverage   30.03%   30.00%   -0.03%     
==========================================
  Files          56       56              
  Lines        7451     7451              
==========================================
- Hits         2238     2236       -2     
- Misses       4968     4971       +3     
+ Partials      245      244       -1     

see 1 file with indirect coverage changes

@k8s-ci-robot k8s-ci-robot merged commit ff1a212 into kubernetes-sigs:master Sep 11, 2023
13 checks passed
@marquiz marquiz deleted the devel/scripts branch September 11, 2023 14:01
@marquiz marquiz mentioned this pull request Dec 20, 2023
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants