Build statically linked binaries #1373
Conversation
Switch to fully statically linked binaries and use scratch as a base image. Switching to the virtually empty scratch base image means that the default/minimal NFD image only supports running hooks that are truly statically linked (e.g. normal go binaries that are "almost" statically linked stop working). The documentation has been already stating this (i.e. that only statically-linked binaries are supported) - i.e. we have had no promise of supporting other than that. Also, hooks are now deprecated and even disabled by default so the possibility of real user impact should be small.
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
approved
✅ Deploy Preview for kubernetes-sigs-nfd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
k8s-ci-robot
added
the
size/S
|
@tkatila had some good questions (in a private chat) about the images and some bells started to ring. I started to dig into my memory and git repo and found this one. It could be time for this... /assign @ArangoGutierrez |
|
@marquiz: GitHub didn't allow me to request PR reviews from the following users: mythi. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 7c0b5a96634116e7a77cd3d3770fab7e65de207a
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ArangoGutierrez, marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1373 +/- ##
=======================================
Coverage 30.02% 30.02%
=======================================
Files 56 56
Lines 7457 7457
=======================================
Hits 2239 2239
Misses 4974 4974
Partials 244 244 |
Switch to fully statically linked binaries and use scratch as a base image.
Switching to the virtually empty scratch base image means that the default/minimal NFD image only supports running hooks that are truly statically linked (e.g. normal go binaries that are "almost" statically linked stop working). The documentation has been already stating this (i.e. that only statically-linked binaries are supported) - i.e. we have had no promise of supporting other than that. Also, hooks are now deprecated and even disabled by default so the possibility of real user impact should be small.