Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apis/nfd: drop one stale comment line #1382

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Sep 27, 2023

Drop a leftover "docstring" comment that wasn't removed with the type it refers to.

Drop a leftover "docstring" comment that wasn't removed with the type it
refers to.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 27, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify
Copy link

netlify bot commented Sep 27, 2023

Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit dbf00dc
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/65141189fba54a0008585047
😎 Deploy Preview https://deploy-preview-1382--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2023
@marquiz
Copy link
Contributor Author

marquiz commented Sep 27, 2023

/assign @fmuyassarov

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 27, 2023
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #1382 (dbf00dc) into master (02dd550) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1382   +/-   ##
=======================================
  Coverage   30.02%   30.02%           
=======================================
  Files          56       56           
  Lines        7457     7457           
=======================================
  Hits         2239     2239           
  Misses       4974     4974           
  Partials      244      244           

@jjacobelli
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 28, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c1507e48c6776c152ce7869868986b8138058923

@k8s-ci-robot k8s-ci-robot merged commit 076ed3c into kubernetes-sigs:master Sep 28, 2023
12 checks passed
@marquiz marquiz deleted the devel/api-cleanup branch September 28, 2023 13:32
@marquiz marquiz mentioned this pull request Dec 20, 2023
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants