-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support raw features #1386
feat: support raw features #1386
Conversation
✅ Deploy Preview for kubernetes-sigs-nfd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/cc @marquiz @ArangoGutierrez |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AhmedGrati. Some really quick comments below. We also need to update the documentation (at least docs/usage/customization-guide.md
) to mention the new directives and the new local.features
feature.
@marquiz: GitHub didn't allow me to request PR reviews from the following users: tkatila, eero-t. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update also to test code and docs would be good.
0bae460
to
128c97a
Compare
c0a125f
to
d0703a7
Compare
37c3230
to
8f67f11
Compare
Signed-off-by: AhmedGrati <ahmedgrati1999@gmail.com>
8f67f11
to
3130898
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big thanks @AhmedGrati for the contribution. I think @tkatila et al will be happy 😊
/lgtm
LGTM label has been added. Git tree hash: d686c6b8143c4c8d5848cc9a25acb9ec1ae9a3b9
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AhmedGrati, marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1386 +/- ##
==========================================
+ Coverage 30.02% 30.14% +0.11%
==========================================
Files 56 56
Lines 7457 7497 +40
==========================================
+ Hits 2239 2260 +21
- Misses 4974 4991 +17
- Partials 244 246 +2
|
Resolves #1376.
Note: I used
no-label
andno-feature
directives instead ofnoLabel
andnoFeature
, to make it consistent withexpiry-time
directive.