Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nfd-master: correctly clean up annotations #1393

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Oct 5, 2023

Delete correct annotations if -instance is specified.

Delete correct annotations if -instance is specified.
@netlify
Copy link

netlify bot commented Oct 5, 2023

Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit 9ea0a1b
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/651e6fc3ab48020008f67941
😎 Deploy Preview https://deploy-preview-1393--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 5, 2023
@marquiz
Copy link
Contributor Author

marquiz commented Oct 5, 2023

/assign @ArangoGutierrez
/cherry-pick release-0.14

@k8s-infra-cherrypick-robot

@marquiz: once the present PR merges, I will cherry-pick it on top of release-0.14 in a new PR and assign it to you.

In response to this:

/assign @ArangoGutierrez
/cherry-pick release-0.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 5, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7fc1ff4840d02f3342b014523ea8c64cce3f5e72

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ArangoGutierrez,marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #1393 (9ea0a1b) into master (7f6fd05) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1393      +/-   ##
==========================================
+ Coverage   30.14%   30.16%   +0.01%     
==========================================
  Files          56       56              
  Lines        7497     7499       +2     
==========================================
+ Hits         2260     2262       +2     
  Misses       4991     4991              
  Partials      246      246              
Files Coverage Δ
pkg/nfd-master/nfd-master.go 45.57% <100.00%> (+0.11%) ⬆️

@k8s-ci-robot k8s-ci-robot merged commit 7c0913e into kubernetes-sigs:master Oct 5, 2023
12 checks passed
@k8s-infra-cherrypick-robot

@marquiz: failed to push cherry-picked changes in GitHub: pushToNamedFork is not implemented in the v2 client

In response to this:

/assign @ArangoGutierrez
/cherry-pick release-0.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@marquiz marquiz deleted the devel/annotations-fix branch October 5, 2023 09:56
@marquiz marquiz mentioned this pull request Dec 20, 2023
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants