nfd-master: stop creating NFD version annotations #1394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-nfd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
k8s-ci-robot
added
approved
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 114b815cf4223ed6f4cf81daac9719facf5df99f
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ArangoGutierrez, marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I think I need to update the e2e-tests too 🙄 |
k8s-ci-robot
added
the
do-not-merge/hold
marquiz
force-pushed
the
devel/annotations
branch
from
ede31e7
to
356957d
Compare
k8s-ci-robot
removed
the
lgtm
|
E2E fixed |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/retest |
We now have metrics for getting detailed information about the NFD instances running. There should be no need to pollute the node object with NFD version annotations. One problem with the annotations also that they were incomplete in the sense that they only covered nfd-master and nfd-worker but not nfd-topology-updater or nfd-gc. Also, there was a problem with stale annotations, giving misleading information. E.g. there was no way to remove old/stale master.version annotations if nfd-master was scheduled on another node where it was previously running.
marquiz
force-pushed
the
devel/annotations
branch
from
356957d
to
1d8a83b
Compare
|
Third time's the charm 🤞 |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 2abbba39541a936a1eabed2813a7be5c1dd35dfd
|
|
Sync with kubernetes/test-infra#30955 |
k8s-ci-robot
added
the
do-not-merge/hold
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1394 +/- ##
==========================================
+ Coverage 30.16% 30.21% +0.05%
==========================================
Files 56 56
Lines 7499 7496 -3
==========================================
+ Hits 2262 2265 +3
+ Misses 4991 4985 -6
Partials 246 246
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now have metrics for getting detailed information about the NFD instances running. There should be no need to pollute the node object with NFD version annotations.
One problem with the annotations also that they were incomplete in the sense that they only covered nfd-master and nfd-worker but not nfd-topology-updater or nfd-gc.
Also, there was a problem with stale annotations, giving misleading information. E.g. there was no way to remove old/stale master.version annotations if nfd-master was scheduled on another node where it was previously running.
Fixes #1352