Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: add example grafana dashboard #1413

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Oct 10, 2023

Example visualization for all metrics except
nfd_node_update_requests_total which counts the deprecated (and disabled-by-default) gRPC requests.

Fixes #1381

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 10, 2023
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2023
@netlify
Copy link

netlify bot commented Oct 10, 2023

Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit b75de2a
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/65258e566a98800008c1209b
😎 Deploy Preview https://deploy-preview-1413--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 10, 2023
@marquiz
Copy link
Contributor Author

marquiz commented Oct 10, 2023

/cc @PiotrProkop @ArangoGutierrez

Example visualization for all metrics except
nfd_node_update_requests_total which counts the deprecated (and
disabled-by-default) gRPC requests.
@marquiz
Copy link
Contributor Author

marquiz commented Oct 10, 2023

Added minimal documentation

Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 12, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 017982567b1a9ebae8293da0c9ab0fa2b2b8ff5b

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ArangoGutierrez,marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #1413 (b75de2a) into master (a379faf) will not change coverage.
Report is 4 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1413   +/-   ##
=======================================
  Coverage   30.33%   30.33%           
=======================================
  Files          58       58           
  Lines        7481     7481           
=======================================
  Hits         2269     2269           
  Misses       4965     4965           
  Partials      247      247           

@k8s-ci-robot k8s-ci-robot merged commit e1d1715 into kubernetes-sigs:master Oct 12, 2023
14 checks passed
@marquiz marquiz mentioned this pull request Dec 20, 2023
24 tasks
@marquiz marquiz deleted the devel/grafana branch December 21, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grafana dashboard
4 participants