Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discover node features as annotations #1417

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Discover node features as annotations #1417

merged 1 commit into from
Oct 26, 2023

Conversation

ArangoGutierrez
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez commented Oct 13, 2023 •
edited
Loading

Fixes #863

@netlify
Copy link

netlify bot commented Oct 13, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit c0063be
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/653957798db7ab00085955bd
😎 Deploy Preview https://deploy-preview-1417--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 13, 2023
@ArangoGutierrez
Copy link
Contributor Author

/assign @marquiz

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 13, 2023
@ArangoGutierrez ArangoGutierrez mentioned this pull request Oct 13, 2023
Closed
@ArangoGutierrez ArangoGutierrez force-pushed the annotations branch 10 times, most recently from 2b7b3f7 to 3aaad73 Compare October 17, 2023 14:02
marquiz
marquiz reviewed Oct 20, 2023
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ArangoGutierrez. Great to move this featre forward. A few comments below.

Also, we need to update docs/usage/customization-guide.md, at least describe the new annotations field of the CR

examples/nodefeaturerule.yaml Outdated Show resolved Hide resolved
test/e2e/e2e_test.go Outdated Show resolved Hide resolved
test/e2e/node_feature_discovery_test.go Outdated Show resolved Hide resolved
pkg/nfd-master/nfd-master.go Outdated Show resolved Hide resolved
pkg/nfd-master/nfd-master.go Outdated Show resolved Hide resolved
pkg/nfd-master/nfd-master.go Outdated Show resolved Hide resolved
test/e2e/node_feature_discovery_test.go Outdated Show resolved Hide resolved
@ArangoGutierrez
Copy link
Contributor Author

@marquiz ready for a second pass

marquiz
marquiz reviewed Oct 24, 2023
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @ArangoGutierrez for the update. There's still something small in nfd-master.go

Plus docs/usage/customization-guide.md needs to be updated.

examples/nodefeaturerule.yaml Outdated Show resolved Hide resolved
pkg/nfd-master/nfd-master.go Show resolved Hide resolved
pkg/nfd-master/nfd-master.go Outdated Show resolved Hide resolved
pkg/nfd-master/nfd-master.go Outdated Show resolved Hide resolved
@ArangoGutierrez
Copy link
Contributor Author

/retest

marquiz
marquiz reviewed Oct 24, 2023
View reviewed changes
pkg/nfd-master/nfd-master.go Outdated Show resolved Hide resolved
pkg/nfd-master/nfd-master.go Outdated Show resolved Hide resolved
docs/usage/customization-guide.md Outdated Show resolved Hide resolved
docs/usage/customization-guide.md Outdated Show resolved Hide resolved
marquiz
marquiz reviewed Oct 25, 2023
View reviewed changes
docs/usage/customization-guide.md Outdated Show resolved Hide resolved
docs/usage/customization-guide.md Show resolved Hide resolved
@ArangoGutierrez @bebc @marquiz
Discover node features as annotations
c0063be 
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
Co-authored-by: bebc <mchf1990212@gmail.com>
Co-authored-by: Markus Lehtonen <markus.lehtonen@intel.com>
marquiz
marquiz approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @ArangoGutierrez (and big thanks @bebc for doing a lot of groundwork in #1093!). This is a great new feature.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 26, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 589f463d961e2beaaa718998984d68c445afe71e

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ArangoGutierrez,marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@marquiz
Copy link
Contributor

marquiz commented Oct 26, 2023

/retest

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #1417 (c0063be) into master (9865b4a) will increase coverage by 0.13%.
Report is 6 commits behind head on master.
The diff coverage is 65.21%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1417      +/-   ##
==========================================
+ Coverage   30.42%   30.55%   +0.13%     
==========================================
  Files          58       58              
  Lines        7488     7534      +46     
==========================================
+ Hits         2278     2302      +24     
- Misses       4962     4982      +20     
- Partials      248      250       +2
Files Coverage Δ
pkg/apis/nfd/v1alpha1/rule.go 79.76% <100.00%> (ø)
pkg/apis/nfd/v1alpha1/zz_generated.deepcopy.go 23.98% <0.00%> (-0.37%) ⬇️
pkg/nfd-master/nfd-master.go 46.14% <70.96%> (+0.59%) ⬆️

@k8s-ci-robot k8s-ci-robot merged commit e2c7c8f into kubernetes-sigs:master Oct 26, 2023
14 checks passed
@marquiz marquiz mentioned this pull request Dec 20, 2023
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marquiz marquiz marquiz approved these changes

@kad kad Awaiting requested review from kad

@PiotrProkop PiotrProkop Awaiting requested review from PiotrProkop

Assignees

@marquiz marquiz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Discover node features as annotations
3 participants
@ArangoGutierrez @k8s-ci-robot @marquiz