nfd-master: fix retry of node updates #1425
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-nfd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
k8s-ci-robot
added
the
approved
This patch addresses issues with slow node status (extended resources) updates. Previously we did just a few retries in quick succession which could result in the node update failing, just because node status was updated slower than our retry window. The patch mitigates the issue by increasing the number of tries to 15. In addition, it creates a ratelimiter with a longer per-item (per-node) base delay. The patch also fixes the e2e-tests to expose the issue.
k8s-ci-robot
added
the
size/S
marquiz
force-pushed
the
devel/node-update-fix
branch
from
41f05a8
to
a9849f2
Compare
|
/assign @ArangoGutierrez |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: fb00e05fe8d0a4089bd1fa6846dbb31777c31d2a
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ArangoGutierrez, marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1425 +/- ##
==========================================
+ Coverage 30.33% 30.39% +0.06%
==========================================
Files 58 58
Lines 7481 7488 +7
==========================================
+ Hits 2269 2276 +7
Misses 4965 4965
Partials 247 247
|
|
/cherry-pick release-0.14 |
|
@marquiz: new pull request created: #1427 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This patch addresses issues with slow node status (extended resources) updates. Previously we did just a few retries in quick succession which could result in the node update failing, just because node status was updated slower than our retry window. The patch mitigates the issue by increasing the number of tries to 15. In addition, it creates a ratelimiter with a longer per-item (per-node) base delay.
The patch also fixes the e2e-tests to expose the issue.