test/e2e: stricter validation of node annotations #1426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that the hard-to-predict version annotations are gone we can do strict validation of nfd-generated node annotations.
✅ Deploy Preview for kubernetes-sigs-nfd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
ArangoGutierrez
approved these changes
Oct 23, 2023
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ArangoGutierrez, marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: 83cdb7f4e900e46ffac863cc9fb86156b32b9cac
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1426 +/- ##
=======================================
Coverage 30.39% 30.39%
=======================================
Files 58 58
Lines 7488 7488
=======================================
Hits 2276 2276
Misses 4965 4965
Partials 247 247 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the hard-to-predict version annotations are gone we can do
strict validation of nfd-generated node annotations.
The PR also contains another patch that drops the now unused ignoreUnexpected arg from custom gomega matcher.