-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: edits to customization guide #1436
docs: edits to customization guide #1436
Conversation
✅ Deploy Preview for kubernetes-sigs-nfd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Requires #1437 for the verify-docs job to pass muster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 2dd466727ea0bfc0851021e8843f96e06f0b55d9
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ArangoGutierrez, marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d4ae422
to
882e1db
Compare
882e1db
to
3561be4
Compare
ping @ArangoGutierrez now the test results are green |
/lgtm |
LGTM label has been added. Git tree hash: e47ab98b80e2e37c8c56db03bd4465e96f663c2b
|
"Feature rule format" is more appropriate as we now support extended resources and taints in addition to labels.
Small edit to how tainting is documented in the customization guide. First, make the heading shorter. Then, move the detailed example yaml and its description further down in the document to the section that describes the "taints" field - this is now similar how extended resources are documented.
Rename the sub-section headings of the "Fields" section (describing the fields of NodeFeatureRule) to match the actual field names (as in YAML).
3561be4
to
0a30cf9
Compare
Rebased |
/lgtm |
LGTM label has been added. Git tree hash: 51b68d46f7086cef3403b62bbd77abf173b80929
|
This PR comprises of a few changes to the customization guide, in an attempt to make it slightly more consistent and readable
"Feature rule format" is more appropriate as we now support extended
resources and taints in addition to labels.
Small edit to how tainting is documented in the customization guide.
First, make the heading shorter. Then, move the detailed example yaml
and its description further down in the document to the section that
describes the "taints" field - this is now similar how extended
resources are documented.
Rename the sub-section headings of the "Fields" section (describing the
fields of NodeFeatureRule) to match the actual field names (as in YAML).