-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: discover virtual network interface #1448
feat: discover virtual network interface #1448
Conversation
✅ Deploy Preview for kubernetes-sigs-nfd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/cc @marquiz |
Thanks @AhmedGrati for this enhancement. I will review it in detail in the near future ping @rwlove |
Would you be able to get the VLAN ID from the interface with this change? |
Signed-off-by: AhmedGrati <ahmedgrati1999@gmail.com>
76419e9
to
59bd846
Compare
59bd846
to
50f22ba
Compare
@marquiz We need to add another mount-point which is |
Hmm, I don't like that. Plus reading it needs root? |
@marquiz reading doesn't require root access. |
/retest |
ping @marquiz |
50f22ba
to
c838d08
Compare
Signed-off-by: AhmedGrati <ahmedgrati1999@gmail.com>
c838d08
to
6aa6590
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my side this looks ready to get in
At least with all the distros I tried (Ubuntu, Fedora, openSUSE) it requires root $ ls /proc/net/vlan/ -l
total 0
-rw------- 1 root root 0 Nov 9 21:13 config
-rw------- 1 root root 0 Nov 9 21:13 eno2.12 |
@marquiz should you assign the merging to someone? |
/assign @ArangoGutierrez |
ping @ArangoGutierrez |
1 similar comment
ping @ArangoGutierrez |
Sorry I was a bit focused on a new feature, will review this today |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: e81e6ca2f16bfea86d45dcb2785422e987bf3ec7
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AhmedGrati, ArangoGutierrez, marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1448 +/- ##
==========================================
+ Coverage 30.55% 33.35% +2.80%
==========================================
Files 58 58
Lines 7527 7956 +429
==========================================
+ Hits 2300 2654 +354
- Misses 4978 5021 +43
- Partials 249 281 +32
|
Resolves #1385.