Create a Validate pkg #1455

ArangoGutierrez · 2023-11-08T16:54:04Z

No description provided.

netlify · 2023-11-08T16:54:12Z

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name	Link
🔨 Latest commit	`affb93e`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/657730ba08a32e0008a30358
😎 Deploy Preview	https://deploy-preview-1455--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ArangoGutierrez · 2023-11-08T17:05:20Z

oh I forgot unit tests at master 😓

marquiz

Thanks @ArangoGutierrez for the PR. Splitting this out of #1446 makes for a lot easier review. I'd keep this patch validation-only and have the dynamic value expansion of labels inside nfd-master

pkg/apis/nfd/validate/validate.go

ArangoGutierrez · 2023-11-21T10:32:58Z

@AhmedGrati @marquiz PTAL

AhmedGrati

Nice improvement @ArangoGutierrez!

ArangoGutierrez · 2023-11-21T14:02:42Z

/assign @marquiz

ArangoGutierrez · 2023-12-01T17:56:48Z

@marquiz @AhmedGrati Rebased, ready for another round

AhmedGrati

@ArangoGutierrez I think it would be a great addition if you can add some unit tests for the validate functions. wdyt?

AhmedGrati

LGTM! Thanks for your efforts @ArangoGutierrez!

pkg/apis/nfd/validate/validate.go

pkg/nfd-master/nfd-master.go

pkg/apis/nfd/validate/validate.go

pkg/apis/nfd/validate/validate_test.go

marquiz · 2023-12-08T19:15:00Z

Oh, and this, i.e. remove the mention that the default namespaces cannot be denied

docs/usage/customization-guide.md

pkg/nfd-master/nfd-master.go

scripts/test-infra/test-e2e.sh

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

marquiz

Thanks @ArangoGutierrez for the contribution. Looks ready for me
/lgtm

k8s-ci-robot · 2023-12-12T08:40:07Z

LGTM label has been added.

Git tree hash: 125fa1e7f300f2a0b1e17b1402b6de5ac44d5c1b

k8s-ci-robot · 2023-12-12T08:40:16Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AhmedGrati, ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [ArangoGutierrez,marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

marquiz · 2023-12-12T09:34:03Z

/retest

codecov · 2023-12-12T10:02:08Z

Codecov Report

Merging #1455 (affb93e) into master (bdfef6d) will increase coverage by 0.73%.
Report is 23 commits behind head on master.
The diff coverage is 81.89%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1455      +/-   ##
==========================================
+ Coverage   30.75%   31.49%   +0.73%     
==========================================
  Files          58       59       +1     
  Lines        7550     7621      +71     
==========================================
+ Hits         2322     2400      +78     
+ Misses       4977     4972       -5     
+ Partials      251      249       -2

Files	Coverage Δ
pkg/apis/nfd/validate/validate.go	`89.41% <89.41%> (ø)`
pkg/nfd-master/nfd-master.go	`45.56% <61.29%> (+1.80%)`	⬆️

... and 2 files with indirect coverage changes

ArangoGutierrez requested a review from marquiz November 8, 2023 16:54

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 8, 2023

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 8, 2023

k8s-ci-robot requested review from adrianchiris and PiotrProkop November 8, 2023 16:54

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2023

ArangoGutierrez force-pushed the validation branch 2 times, most recently from d511a1f to 82bbc05 Compare November 8, 2023 16:55

marquiz reviewed Nov 9, 2023

View reviewed changes

pkg/apis/nfd/validate/validate.go Outdated Show resolved Hide resolved

pkg/apis/nfd/validate/validate.go Outdated Show resolved Hide resolved

ArangoGutierrez force-pushed the validation branch 2 times, most recently from 22dc311 to 3bd2ecd Compare November 9, 2023 13:50

ArangoGutierrez requested a review from marquiz November 9, 2023 13:50

AhmedGrati reviewed Nov 10, 2023

View reviewed changes

pkg/apis/nfd/validate/validate.go Outdated Show resolved Hide resolved

pkg/apis/nfd/validate/validate.go Outdated Show resolved Hide resolved

pkg/apis/nfd/validate/validate.go Outdated Show resolved Hide resolved

ArangoGutierrez force-pushed the validation branch from 3bd2ecd to a341513 Compare November 21, 2023 10:32

ArangoGutierrez requested a review from AhmedGrati November 21, 2023 10:32

AhmedGrati approved these changes Nov 21, 2023

View reviewed changes

k8s-ci-robot assigned marquiz Nov 21, 2023

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 24, 2023

ArangoGutierrez force-pushed the validation branch from a341513 to 456217d Compare December 1, 2023 17:56

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 1, 2023

ArangoGutierrez requested a review from AhmedGrati December 1, 2023 17:56

AhmedGrati approved these changes Dec 2, 2023

View reviewed changes

AhmedGrati reviewed Dec 2, 2023

View reviewed changes

ArangoGutierrez mentioned this pull request Dec 3, 2023

Release v0.15 #1483

Closed

24 tasks

ArangoGutierrez force-pushed the validation branch from 456217d to 048814b Compare December 4, 2023 10:26

ArangoGutierrez requested a review from AhmedGrati December 5, 2023 15:23

AhmedGrati approved these changes Dec 5, 2023

View reviewed changes

marquiz reviewed Dec 7, 2023

View reviewed changes

pkg/apis/nfd/validate/validate.go Outdated Show resolved Hide resolved

pkg/apis/nfd/validate/validate.go Outdated Show resolved Hide resolved

pkg/apis/nfd/validate/validate.go Outdated Show resolved Hide resolved

ArangoGutierrez force-pushed the validation branch from 11071d3 to 5243e91 Compare December 7, 2023 18:56

ArangoGutierrez requested a review from marquiz December 7, 2023 18:56

ArangoGutierrez force-pushed the validation branch from 5243e91 to f35bb58 Compare December 7, 2023 18:58

marquiz reviewed Dec 8, 2023

View reviewed changes

ArangoGutierrez force-pushed the validation branch from f35bb58 to acab880 Compare December 8, 2023 15:24

ArangoGutierrez requested a review from marquiz December 8, 2023 15:24

ArangoGutierrez force-pushed the validation branch from acab880 to b397eb3 Compare December 8, 2023 18:31

marquiz reviewed Dec 8, 2023

View reviewed changes

pkg/apis/nfd/validate/validate.go Outdated Show resolved Hide resolved

marquiz reviewed Dec 8, 2023

View reviewed changes

pkg/apis/nfd/validate/validate.go Show resolved Hide resolved

marquiz reviewed Dec 8, 2023

View reviewed changes

pkg/apis/nfd/validate/validate_test.go Show resolved Hide resolved

ArangoGutierrez commented Dec 8, 2023

View reviewed changes

docs/usage/customization-guide.md Show resolved Hide resolved

ArangoGutierrez force-pushed the validation branch from b397eb3 to e585849 Compare December 11, 2023 10:11

ArangoGutierrez requested a review from marquiz December 11, 2023 10:11

marquiz reviewed Dec 11, 2023

View reviewed changes

pkg/nfd-master/nfd-master.go Outdated Show resolved Hide resolved

marquiz reviewed Dec 11, 2023

View reviewed changes

scripts/test-infra/test-e2e.sh Outdated Show resolved Hide resolved

Create a Validate pkg

affb93e

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

ArangoGutierrez force-pushed the validation branch from e585849 to affb93e Compare December 11, 2023 15:54

ArangoGutierrez requested a review from marquiz December 11, 2023 15:54

marquiz approved these changes Dec 12, 2023

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2023

k8s-ci-robot merged commit efe5c03 into kubernetes-sigs:master Dec 12, 2023
14 checks passed

ArangoGutierrez mentioned this pull request Dec 12, 2023

Add Kubectl NFD plugin #1446

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create a Validate pkg #1455

Create a Validate pkg #1455

ArangoGutierrez commented Nov 8, 2023

netlify bot commented Nov 8, 2023 •

edited

Loading

ArangoGutierrez commented Nov 8, 2023

marquiz left a comment

ArangoGutierrez commented Nov 21, 2023

AhmedGrati left a comment

ArangoGutierrez commented Nov 21, 2023

ArangoGutierrez commented Dec 1, 2023

AhmedGrati left a comment

AhmedGrati left a comment

marquiz commented Dec 8, 2023

marquiz left a comment

k8s-ci-robot commented Dec 12, 2023

k8s-ci-robot commented Dec 12, 2023

marquiz commented Dec 12, 2023

codecov bot commented Dec 12, 2023

Create a Validate pkg #1455

Create a Validate pkg #1455

Conversation

ArangoGutierrez commented Nov 8, 2023

netlify bot commented Nov 8, 2023 • edited Loading

✅ Deploy Preview for kubernetes-sigs-nfd ready!

ArangoGutierrez commented Nov 8, 2023

marquiz left a comment

Choose a reason for hiding this comment

ArangoGutierrez commented Nov 21, 2023

AhmedGrati left a comment

Choose a reason for hiding this comment

ArangoGutierrez commented Nov 21, 2023

ArangoGutierrez commented Dec 1, 2023

AhmedGrati left a comment

Choose a reason for hiding this comment

AhmedGrati left a comment

Choose a reason for hiding this comment

marquiz commented Dec 8, 2023

marquiz left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Dec 12, 2023

k8s-ci-robot commented Dec 12, 2023

marquiz commented Dec 12, 2023

codecov bot commented Dec 12, 2023

Codecov Report

netlify bot commented Nov 8, 2023 •

edited

Loading