apis/nfd: drop creation helper functions #1481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-nfd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
k8s-ci-robot
added
approved
|
Unit tests fail until #1480 is in |
marquiz
force-pushed
the
devel/api-creation-funcs
branch
from
d9cb069
to
5801e9e
Compare
|
Rebased |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: b8f1d7527542a2c2087ee8a9546e20c3e9745dc9
|
Drop the creation helper functions as one step in an effort to tidy up the api package. These functions were not much used outside unit tests anyway, the static rules of the nfd-worker custom feature source being the only exception (and if those happened to be invalid we'd catch that e.g. in the e2e-tests).
marquiz
force-pushed
the
devel/api-creation-funcs
branch
from
5801e9e
to
0bc1b6c
Compare
k8s-ci-robot
removed
the
lgtm
|
Rebased. |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: bbe93c8118348172bccc92637fd00a1b6e393e3f
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ArangoGutierrez, marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1481 +/- ##
==========================================
- Coverage 31.46% 31.39% -0.08%
==========================================
Files 59 59
Lines 7563 7555 -8
==========================================
- Hits 2380 2372 -8
- Misses 4937 4939 +2
+ Partials 246 244 -2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop the creation helper functions as one step in an effort to tidy up the api package. These functions were not much used outside unit tests anyway, the static rules of the nfd-worker custom feature source being the only exception (and if those happened to be invalid we'd catch that e.g. in the e2e-tests).