apis/nfd: drop the private regexp caching field #1482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop the private field for caching parsed regexp from the MatchExpression type. This tidies up the API type definition and not so tied with particular implementation details. The change also elimiates potential concurrency problems as no locking is in place in the API types. If caching will be desired in the future, it's better to do it properly in a separate package, not directly in the API types.
✅ Deploy Preview for kubernetes-sigs-nfd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
k8s-ci-robot
added
cncf-cla: yes
ArangoGutierrez
approved these changes
Dec 14, 2023
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: f0c353c7fa7616d97e692a3b3846061b69223b5a
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ArangoGutierrez, marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1482 +/- ##
==========================================
+ Coverage 30.75% 35.42% +4.67%
==========================================
Files 58 59 +1
Lines 7550 8118 +568
==========================================
+ Hits 2322 2876 +554
+ Misses 4977 4962 -15
- Partials 251 280 +29
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop the private field for caching parsed regexp from the MatchExpression type. This tidies up the API type definition and not so tied with particular implementation details. The change also elimiates potential concurrency problems as no locking is in place in the API types.
If caching will be desired in the future, it's better to do it properly in a separate package, not directly in the API types.
Ref: #1477