Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: fix e2e-testing of the full image #1500

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Dec 12, 2023

Fix syntax error in the shell code. Also enable verbosity to print out the shell script being run.

Fix syntax error in the shell code. Also enable verbosity to print out
the shell script being run.
Copy link

netlify bot commented Dec 12, 2023

Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit 4ebe58f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/6578274efe3ce200089019da
😎 Deploy Preview https://deploy-preview-1500--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 12, 2023
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2023
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ArangoGutierrez,marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f3abd47140cd5da43e5f222ad43ec2eb243f9d10

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Merging #1500 (4ebe58f) into master (795c356) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1500   +/-   ##
=======================================
  Coverage   30.66%   30.66%           
=======================================
  Files          58       58           
  Lines        7571     7571           
=======================================
  Hits         2322     2322           
  Misses       4998     4998           
  Partials      251      251           

@k8s-ci-robot k8s-ci-robot merged commit c0d7905 into kubernetes-sigs:master Dec 12, 2023
12 checks passed
@marquiz marquiz deleted the devel/makefile-fix-e2e branch December 12, 2023 10:06
@marquiz marquiz mentioned this pull request Dec 20, 2023
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants