Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: bump kubernetes to v1.29 #1509

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Dec 20, 2023

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 20, 2023
Copy link

netlify bot commented Dec 20, 2023

Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit ea68017
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/6582ea660190240008ca4781
😎 Deploy Preview https://deploy-preview-1509--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 20, 2023
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v0.15!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 20, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5498dfa1a7789664202c7cdd69aeeb78e6f7a3d9

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ArangoGutierrez,marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Use "k8s.io/utils/ptr" instead of the deprecated "k8s.io/utils/pointer".
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 20, 2023
Copy link
Member

@fmuyassarov fmuyassarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 20, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: eb6f58108d3106e7f408c777ae861f82139eca68

@marquiz
Copy link
Contributor Author

marquiz commented Dec 20, 2023

/retest

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9de86b0) 31.31% compared to head (ea68017) 31.31%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1509   +/-   ##
=======================================
  Coverage   31.31%   31.31%           
=======================================
  Files          61       61           
  Lines        7722     7722           
=======================================
  Hits         2418     2418           
  Misses       5060     5060           
  Partials      244      244           

@k8s-ci-robot k8s-ci-robot merged commit 1a5659f into kubernetes-sigs:master Dec 20, 2023
12 checks passed
@marquiz marquiz deleted the devel/deps-k8s branch December 20, 2023 14:15
@marquiz marquiz mentioned this pull request Dec 20, 2023
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants