Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix wording and nfd version in master config ref #1520

Merged
merged 1 commit into from
Dec 21, 2023
Merged

docs: fix wording and nfd version in master config ref #1520

merged 1 commit into from
Dec 21, 2023

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Dec 21, 2023

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 21, 2023
@netlify Netlify
Copy link

netlify bot commented Dec 21, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit 304785a
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/658467e42cd6e3000853e3dc
😎 Deploy Preview https://deploy-preview-1520--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 21, 2023
@marquiz marquiz force-pushed the devel/docs-fix-master-config-ref branch from 30ce52c to 304785a Compare December 21, 2023 16:29
ArangoGutierrez
ArangoGutierrez approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 21, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ArangoGutierrez,marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c9d710bfd76102e2ebe4934c99b5cc4c953e17c6

@k8s-ci-robot k8s-ci-robot merged commit 2f99038 into kubernetes-sigs:master Dec 21, 2023
8 checks passed
@marquiz marquiz deleted the devel/docs-fix-master-config-ref branch December 21, 2023 16:44
@marquiz marquiz mentioned this pull request Dec 22, 2023
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArangoGutierrez ArangoGutierrez ArangoGutierrez approved these changes

@fmuyassarov fmuyassarov Awaiting requested review from fmuyassarov

@jjacobelli jjacobelli Awaiting requested review from jjacobelli

Assignees

@ArangoGutierrez ArangoGutierrez

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marquiz @k8s-ci-robot @ArangoGutierrez