-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] feat: configure CR restrictions #1540
[WIP] feat: configure CR restrictions #1540
Conversation
Skipping CI for Draft Pull Request. |
✅ Deploy Preview for kubernetes-sigs-nfd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
8c3713e
to
b641da1
Compare
Thanks @AhmedGrati for working on this. Will look at it later |
b641da1
to
4c979a4
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AhmedGrati The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
10614db
to
106c04a
Compare
106c04a
to
284a56e
Compare
Signed-off-by: AhmedGrati <ahmedgrati1999@gmail.com>
284a56e
to
b4ef825
Compare
Signed-off-by: AhmedGrati <ahmedgrati1999@gmail.com>
b4ef825
to
5f7569f
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1540 +/- ##
==========================================
+ Coverage 31.15% 31.21% +0.05%
==========================================
Files 62 62
Lines 7774 7798 +24
==========================================
+ Hits 2422 2434 +12
- Misses 5108 5114 +6
- Partials 244 250 +6
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks you @AhmedGrati for working on this feature. Some comments below
case "deny-node-feature-labels": | ||
args.Overrides.DenyNodeFeatureLabels = overrides.DenyNodeFeatureLabels | ||
case "overwrite-labels": | ||
args.Overrides.OverwriteLabels = overrides.OverwriteLabels |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could have these as config file options only, if you want to keep things simple. E.g. the leader election parameters are config-file-only so this is asymmetric, already. WDYT?
@@ -47,13 +48,15 @@ type nfdController struct { | |||
type nfdApiControllerOptions struct { | |||
DisableNodeFeature bool | |||
ResyncPeriod time.Duration | |||
AllowedNamespaces []string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, looking at this now I think we could do better (more k8s-like). Could we use metav1.LabelSelector directly. It would make it very flexible to pick up the namespaces to watch. The name of the config option would be something like nodeFeatureNamespaceSelector
. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I got this correctly, users would need to pass a map (instead of an array) to specify selectors, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or even use the metav1.LabelSelector type directly?
@marquiz I think we can close this. |
ping @marquiz, can we close this? |
Superseded by #1592 |
@marquiz: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
POC of #1380
Things TBD: