Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.16] Fix the problem with starting the master with empty cache #1740

Conversation

k8s-infra-cherrypick-robot

This is an automated cherry-pick of #1739

/assign marquiz

We faced the problem when master deleted some of labels on start. Sometimes he doesn't gets NodeFeatures when they are present in cluster because of empty cache in informer
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 10, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 10, 2024
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 10, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: df03ccab7c4af8c4daf7664e03379cf132cc1f06

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k8s-infra-cherrypick-robot, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2024
Copy link

codecov bot commented Jun 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 39.50%. Comparing base (c296eda) to head (1a18bcd).
Report is 1 commits behind head on release-0.16.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           release-0.16    #1740      +/-   ##
================================================
- Coverage         39.51%   39.50%   -0.01%     
================================================
  Files                80       80              
  Lines              7160     7161       +1     
================================================
  Hits               2829     2829              
- Misses             4071     4072       +1     
  Partials            260      260              
Files Coverage Δ
pkg/nfd-master/nfd-api-controller.go 9.01% <0.00%> (-0.08%) ⬇️

@k8s-ci-robot k8s-ci-robot merged commit 9f90a59 into kubernetes-sigs:release-0.16 Jun 10, 2024
8 checks passed
kireque pushed a commit to kireque/home-ops that referenced this pull request Jul 3, 2024
)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[node-feature-discovery](https://github.com/kubernetes-sigs/node-feature-discovery)
| patch | `0.16.0` -> `0.16.1` |

---

### Release Notes

<details>
<summary>kubernetes-sigs/node-feature-discovery
(node-feature-discovery)</summary>

###
[`v0.16.1`](https://github.com/kubernetes-sigs/node-feature-discovery/releases/tag/v0.16.1)

[Compare
Source](https://github.com/kubernetes-sigs/node-feature-discovery/compare/v0.16.0...v0.16.1)

#### What's Changed

- \[release-0.16] Revert "build(deps): bump actions/checkout from 1 to
4" by
[@&#8203;k8s-infra-cherrypick-robot](https://github.com/k8s-infra-cherrypick-robot)
in
[kubernetes-sigs/node-feature-discovery#1721
- \[release-0.16] topology-updater: properly handle IPv6 from
NODE_ADDRESS by
[@&#8203;k8s-infra-cherrypick-robot](https://github.com/k8s-infra-cherrypick-robot)
in
[kubernetes-sigs/node-feature-discovery#1731
- \[release-0.16] helm: remove defaults CPU limits by
[@&#8203;k8s-infra-cherrypick-robot](https://github.com/k8s-infra-cherrypick-robot)
in
[kubernetes-sigs/node-feature-discovery#1736
- \[release-0.16] Fix the problem with starting the master with empty
cache by
[@&#8203;k8s-infra-cherrypick-robot](https://github.com/k8s-infra-cherrypick-robot)
in
[kubernetes-sigs/node-feature-discovery#1740
- \[release-0.16] ensure post-delete-job's service account matches ref
in job spec by
[@&#8203;k8s-infra-cherrypick-robot](https://github.com/k8s-infra-cherrypick-robot)
in
[kubernetes-sigs/node-feature-discovery#1750

**Full Changelog**:
kubernetes-sigs/node-feature-discovery@v0.16.0...v0.16.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjIuNCIsInVwZGF0ZWRJblZlciI6IjM3LjQyMi40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9oZWxtIiwidHlwZS9wYXRjaCJdfQ==-->

Co-authored-by: kireque-bot[bot] <143391978+kireque-bot[bot]@users.noreply.github.com>
nrdufour pushed a commit to nrdufour/home-ops that referenced this pull request Jul 4, 2024
…477)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [node-feature-discovery](https://github.com/kubernetes-sigs/node-feature-discovery) | patch | `0.16.0` -> `0.16.1` |

---

### Release Notes

<details>
<summary>kubernetes-sigs/node-feature-discovery (node-feature-discovery)</summary>

### [`v0.16.1`](https://github.com/kubernetes-sigs/node-feature-discovery/releases/tag/v0.16.1)

[Compare Source](kubernetes-sigs/node-feature-discovery@v0.16.0...v0.16.1)

#### What's Changed

-   \[release-0.16] Revert "build(deps): bump actions/checkout from 1 to 4" by [@&#8203;k8s-infra-cherrypick-robot](https://github.com/k8s-infra-cherrypick-robot) in kubernetes-sigs/node-feature-discovery#1721
-   \[release-0.16] topology-updater: properly handle IPv6 from NODE_ADDRESS by [@&#8203;k8s-infra-cherrypick-robot](https://github.com/k8s-infra-cherrypick-robot) in kubernetes-sigs/node-feature-discovery#1731
-   \[release-0.16] helm: remove defaults CPU limits by [@&#8203;k8s-infra-cherrypick-robot](https://github.com/k8s-infra-cherrypick-robot) in kubernetes-sigs/node-feature-discovery#1736
-   \[release-0.16] Fix the problem with starting the master with empty cache by [@&#8203;k8s-infra-cherrypick-robot](https://github.com/k8s-infra-cherrypick-robot) in kubernetes-sigs/node-feature-discovery#1740
-   \[release-0.16] ensure post-delete-job's service account matches ref in job spec by [@&#8203;k8s-infra-cherrypick-robot](https://github.com/k8s-infra-cherrypick-robot) in kubernetes-sigs/node-feature-discovery#1750

**Full Changelog**: kubernetes-sigs/node-feature-discovery@v0.16.0...v0.16.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjIuMCIsInVwZGF0ZWRJblZlciI6IjM3LjQyMi4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Reviewed-on: https://git.internal/nrdufour/home-ops/pulls/477
Co-authored-by: Renovate <renovate@ptinem.casa>
Co-committed-by: Renovate <renovate@ptinem.casa>
lumiere-bot bot added a commit to coolguy1771/home-ops that referenced this pull request Jul 6, 2024
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[node-feature-discovery](https://github.com/kubernetes-sigs/node-feature-discovery)
| patch | `0.16.0` -> `0.16.1` |

---

### Release Notes

<details>
<summary>kubernetes-sigs/node-feature-discovery
(node-feature-discovery)</summary>

###
[`v0.16.1`](https://github.com/kubernetes-sigs/node-feature-discovery/releases/tag/v0.16.1)

[Compare
Source](https://github.com/kubernetes-sigs/node-feature-discovery/compare/v0.16.0...v0.16.1)

#### What's Changed

- \[release-0.16] Revert "build(deps): bump actions/checkout from 1 to
4" by
[@&#8203;k8s-infra-cherrypick-robot](https://github.com/k8s-infra-cherrypick-robot)
in
[kubernetes-sigs/node-feature-discovery#1721
- \[release-0.16] topology-updater: properly handle IPv6 from
NODE_ADDRESS by
[@&#8203;k8s-infra-cherrypick-robot](https://github.com/k8s-infra-cherrypick-robot)
in
[kubernetes-sigs/node-feature-discovery#1731
- \[release-0.16] helm: remove defaults CPU limits by
[@&#8203;k8s-infra-cherrypick-robot](https://github.com/k8s-infra-cherrypick-robot)
in
[kubernetes-sigs/node-feature-discovery#1736
- \[release-0.16] Fix the problem with starting the master with empty
cache by
[@&#8203;k8s-infra-cherrypick-robot](https://github.com/k8s-infra-cherrypick-robot)
in
[kubernetes-sigs/node-feature-discovery#1740
- \[release-0.16] ensure post-delete-job's service account matches ref
in job spec by
[@&#8203;k8s-infra-cherrypick-robot](https://github.com/k8s-infra-cherrypick-robot)
in
[kubernetes-sigs/node-feature-discovery#1750

**Full Changelog**:
kubernetes-sigs/node-feature-discovery@v0.16.0...v0.16.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjIuNCIsInVwZGF0ZWRJblZlciI6IjM3LjQyMi40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9oZWxtIiwidHlwZS9wYXRjaCJdfQ==-->

Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
lambchop4prez added a commit to lambchop4prez/network that referenced this pull request Jul 6, 2024
)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[node-feature-discovery](https://github.com/kubernetes-sigs/node-feature-discovery)
| minor | `0.15.4` -> `0.16.1` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>kubernetes-sigs/node-feature-discovery
(node-feature-discovery)</summary>

###
[`v0.16.1`](https://github.com/kubernetes-sigs/node-feature-discovery/releases/tag/v0.16.1)

[Compare
Source](https://github.com/kubernetes-sigs/node-feature-discovery/compare/v0.16.0...v0.16.1)

#### What's Changed

- \[release-0.16] Revert "build(deps): bump actions/checkout from 1 to
4" by
[@&#8203;k8s-infra-cherrypick-robot](https://github.com/k8s-infra-cherrypick-robot)
in
[kubernetes-sigs/node-feature-discovery#1721
- \[release-0.16] topology-updater: properly handle IPv6 from
NODE_ADDRESS by
[@&#8203;k8s-infra-cherrypick-robot](https://github.com/k8s-infra-cherrypick-robot)
in
[kubernetes-sigs/node-feature-discovery#1731
- \[release-0.16] helm: remove defaults CPU limits by
[@&#8203;k8s-infra-cherrypick-robot](https://github.com/k8s-infra-cherrypick-robot)
in
[kubernetes-sigs/node-feature-discovery#1736
- \[release-0.16] Fix the problem with starting the master with empty
cache by
[@&#8203;k8s-infra-cherrypick-robot](https://github.com/k8s-infra-cherrypick-robot)
in
[kubernetes-sigs/node-feature-discovery#1740
- \[release-0.16] ensure post-delete-job's service account matches ref
in job spec by
[@&#8203;k8s-infra-cherrypick-robot](https://github.com/k8s-infra-cherrypick-robot)
in
[kubernetes-sigs/node-feature-discovery#1750

**Full Changelog**:
kubernetes-sigs/node-feature-discovery@v0.16.0...v0.16.1

###
[`v0.16.0`](https://github.com/kubernetes-sigs/node-feature-discovery/releases/tag/v0.16.0):
v0.16

[Compare
Source](https://github.com/kubernetes-sigs/node-feature-discovery/compare/v0.15.4...v0.16.0)

#### Changelog

##### NodeFeatureGroup API

The NodeFeatureGroup custom resource was added to the NFD API. The
NodeFeatureGroup API enables the creation of node groups based on
features discovered by NFD. The API is an alpha feature and is disabled
by default and can be enabled with the NodeFeatureGroupAPI [feature
gate](https://kubernetes-sigs.github.io/node-feature-discovery/v0.16/usage/custom-resources.html#nodefeaturegroup).

See
[documentation](https://kubernetes-sigs.github.io/node-feature-discovery/v0.16/usage/custom-resources.html#nodefeaturegroup)
for more details.

##### Feature gates

NFD adapted the concept of feature gates from Kubernetes to introduce
and stabilize new features in a controlled way. See the
[documentation](https://kubernetes-sigs.github.io/node-feature-discovery/v0.16/reference/feature-gates.html)
for more details. Two existing features ([NodeFeature
API](https://kubernetes-sigs.github.io/node-feature-discovery/v0.16/reference/feature-gates.html#nodefeatureapi)
and [disabling label
auto-prefixing](https://kubernetes-sigs.github.io/node-feature-discovery/v0.16/reference/feature-gates.html#disableautoprefix))
were converted into feature gates.

##### Deprecations

##### Upcoming changes

Support for
[hooks](https://kubernetes-sigs.github.io/node-feature-discovery/v0.16/usage/customization-guide.html#hooks)
is deprecated since
[v0.12.0](https://github.com/kubernetes-sigs/node-feature-discovery/releases/tag/v0.12.0)
and will be completely dropped in the NFD v0.17.

##### RDT feature labels removed

The `feature.node.kubernetes.io/cpu-rdt.*` feature labels that were
deprecated in NFD
[v0.13](https://github.com/kubernetes-sigs/node-feature-discovery/releases/tag/v0.13.0)
were removed. RDT features are still available for use in
[NodeFeatureRules](https://kubernetes-sigs.github.io/node-feature-discovery/v0.16/usage/custom-resources.html#nodefeaturerule)
for custom labels.

##### Deprecated flags and options

The
[autoDefaultNs](https://kubernetes-sigs.github.io/node-feature-discovery/v0.16/reference/master-configuration-reference.html#autodefaultns)
config file option of nfd-master is deprecated and will be removed in
NFD v0.17. Superseded by the
[DisableAutoPrefix](https://kubernetes-sigs.github.io/node-feature-discovery/v0.16/reference/feature-gates.html#disableautoprefix)
feature gate (`featureGates.DisableAutoPrefix` Helm parameter).

The `-enable-nodefeature-api` command line flag of nfd-master and
nfd-worker and the corresponding `enableNodeFeatureApi` [Helm chart
parameter](https://kubernetes-sigs.github.io/node-feature-discovery/v0.16/deployment/helm.html#general-parameters)
have been deprecated and will be removed in NFD v0.17. Superseded by the
[NodeFeature
API](https://kubernetes-sigs.github.io/node-feature-discovery/v0.16/reference/feature-gates.html#nodefeatureapi)
feature gate (`featureGates.NodeFeatureAPI` Helm parameter).

The `-crd-controller` command line flag of nfd-master is deprecated and
will be removed with the gRPC API in a future release.

##### Miscellaneous

##### Network devices

Discover speed of virtual network interfaces.

##### DMI

Added support for detecting DMI attributes from
`/sys/devices/virtual/dmi/id/`. In v0.16 only `sys_vendor` discovered,
available as `system.dmiid.sys_vendor` feature for use in
[NodeFeatureRules](https://kubernetes-sigs.github.io/node-feature-discovery/v0.16/usage/custom-resources.html#nodefeaturerule).

##### Swap

Discover the availability of swap on the node. Available as
`memory.swap.enabled` feature for use in
[NodeFeatureRules](https://kubernetes-sigs.github.io/node-feature-discovery/v0.16/usage/custom-resources.html#nodefeaturerule).

##### Helm chart

Now all nodes are cleaned up (feature labels, annotations, extended
resources and taints are removed) after uninstalling NFD using a
post-delete hook.

The Helm chart now sets resource requests (cpu and memory) for NFD pods.
Users may want to adjust these for their cluster. An option to set the
pod priority class was added. See [Helm chart
parameters](https://kubernetes-sigs.github.io/node-feature-discovery/v0.16/deployment/helm.html#chart-parameters)
in the documentation).

##### Container health

A gRPC health server was added to the nfd-master, nfd-worker and
nfd-topology-updater daemons. Deployments (Helm and kustomize) configure
container liveness and readiness probes to use that for health checking.

#### List of PRs

- github: update tagging instructions in release checklists
([#&#8203;1527](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1527))
- Update readme to v0.15.0 release
([#&#8203;1524](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1524))
- makefile: fix build: target
([#&#8203;1528](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1528))
- Makefile: add -timeout argument to e2e-tests
([#&#8203;1526](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1526))
- helm: add post-delete hook that cleans up the node
([#&#8203;1532](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1532))
- deployment/kustomize: drop the sample cert-manager overlay
([#&#8203;1534](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1534))
- nfd-master: run a separate gRPC health server
([#&#8203;1535](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1535))
- source/network: discover speed of virtual network interfaces
([#&#8203;1536](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1536))
- go.mod: update dependencies
([#&#8203;1539](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1539))
- chore: combine cpu count and thread_siblings functions into discover
topology function
([#&#8203;1505](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1505))
- source/cpu: drop deprecated cpu-rdt labels
([#&#8203;1530](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1530))
- Update readme to v0.15.1 release
([#&#8203;1552](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1552))
- hack/generate: patch auto-generated deepcopy functions
([#&#8203;1553](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1553))
- apis/nfd: Trivial typo fix in tests
([#&#8203;1537](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1537))
- docs: update docs build dependencies
([#&#8203;1543](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1543))
- topology-updater: initialize properly with -no-publish
([#&#8203;1554](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1554))
- topology-updater: document the -no-publish flag correctly
([#&#8203;1555](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1555))
- Wrap nested errors
([#&#8203;1558](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1558))
- Prevent `nfd-worker` erroring when reading attributes from paravirtual
devices
([#&#8203;1557](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1557))
- pkg/utils: move GetKubeconfig from pkg/apihelper here
([#&#8203;1562](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1562))
- OWNERS: add AhmedGrati as a reviewer
([#&#8203;1564](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1564))
- deployment/helm: don't deploy topology-updater conf unnecessarily
([#&#8203;1565](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1565))
- topology-updater: get topology api client directly
([#&#8203;1566](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1566))
- pkg/utils: move JsonPatch from pkg/apihelper
([#&#8203;1568](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1568))
- nfd-master: ditch apihelper
([#&#8203;1570](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1570))
- topology-updater: ditch apihelper
([#&#8203;1567](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1567))
- Drop pkg/apihelper
([#&#8203;1561](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1561))
- nfd-master: fix node status patching
([#&#8203;1571](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1571))
- nfd-topology-updater add pods fingerprint by default
([#&#8203;1560](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1560))
- docs: add KEP of Spiffe integration
([#&#8203;1444](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1444))
- docs: document removal of hooks in v0.17
([#&#8203;1573](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1573))
- build(deps): bump github.com/opencontainers/runc from 1.1.10 to 1.1.12
([#&#8203;1575](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1575))
- build(deps-dev): bump nokogiri from 1.16.0 to 1.16.2 in /docs
([#&#8203;1576](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1576))
- scripts/test-infra: bump golangci-lint to v1.56.1
([#&#8203;1580](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1580))
- scripts/test-infra: bump k8s logcheck to v0.8.1
([#&#8203;1583](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1583))
- Bump Go to v1.22
([#&#8203;1579](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1579))
- scripts/test-infra: bump helm to v3.14.0
([#&#8203;1582](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1582))
- source/kernel: add unit tests for kernel version parsing
([#&#8203;1588](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1588))
- helm: add priorityClassName option
([#&#8203;1587](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1587))
- source/pci: add unit test for the pci source
([#&#8203;1589](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1589))
- nfd-master: log errors on node update retries
([#&#8203;1591](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1591))
- source/system: Add reading vendor information
([#&#8203;1574](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1574))
- source/cpu: fix build tags on rdt discovery
([#&#8203;1594](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1594))
- helm: add ability to use a custom issuer
([#&#8203;1598](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1598))
- fix hook issue
([#&#8203;1604](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1604))
- generate: update autogenerate tools
([#&#8203;1606](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1606))
- apis/nfd/validate: use testify/assert for checking test results
([#&#8203;1590](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1590))
- Update readme to v0.15.2 release
([#&#8203;1611](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1611))
- Update generate scripts to use latest code_gen functions
([#&#8203;1605](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1605))
- nfd-master: mark the -crd-controller flag as deprecated
([#&#8203;1612](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1612))
- build(deps): bump google.golang.org/protobuf from 1.32.0 to 1.33.0
([#&#8203;1613](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1613))
- Use close to signal stop channedl in worker and topology-updater
([#&#8203;1620](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1620))
- nfd-master: fix memory leak in nfd api-controller
([#&#8203;1615](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1615))
- Update readme to v0.15.3 release
([#&#8203;1628](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1628))
- Add FeatureGate framework to handle new features
([#&#8203;1623](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1623))
- replace AhmedGrati account with TessaIO as reviewer
([#&#8203;1630](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1630))
- add swap support in nfd
([#&#8203;1585](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1585))
- nfd-master: check if node exists before trying update
([#&#8203;1595](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1595))
- Remove references to -enable-nodefeature-api flag
([#&#8203;1632](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1632))
- Add owner reference to NRT object
([#&#8203;1602](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1602))
- nfd-master: retry node updates indefinitely
([#&#8203;1596](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1596))
- nfd-worker: Add liveness probe
([#&#8203;1609](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1609))
- topology-updater: Set APIVersion, Kind in the OwnerReference
explicitly
([#&#8203;1634](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1634))
- helm: fix invalid name of host-swaps volume
([#&#8203;1635](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1635))
- nfd-master: do nfd API scheme registration in an init function
([#&#8203;1641](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1641))
- chore/deployment: add resources requests and limits for helm and
Kustomize
([#&#8203;1631](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1631))
- nfd-topology-updater: Add liveness probe
([#&#8203;1643](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1643))
- nfd-master: get node object only once when updating node
([#&#8203;1652](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1652))
- chore/deploy: make interval property in PodMonitor configurable
([#&#8203;1639](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1639))
- nfd-master: protect node updater pool queueing with a lock
([#&#8203;1642](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1642))
- nfd-master: prevent crash on empty config struct
([#&#8203;1657](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1657))
- Update readme to v0.15.4 release
([#&#8203;1650](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1650))
- Tidy up usage of channels for signaling
([#&#8203;1656](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1656))
- nfd-master: implement opts for modifying NfdMaster instance
([#&#8203;1658](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1658))
- nfd-master: parse kubeconfig even with NoPublish set
([#&#8203;1655](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1655))
- Move NFD api to a separate go mod
([#&#8203;1600](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1600))
- api/nfd: run go mod tidy
([#&#8203;1661](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1661))
- Fix Make generate
([#&#8203;1662](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1662))
- apis/nfd/validate: loosen validation of feature annotations
([#&#8203;1633](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1633))
- nfd-master: use separate k8s api clients for each updater
([#&#8203;1653](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1653))
- nfd-master: stop node-updater pool before reconfiguring api-controller
([#&#8203;1660](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1660))
- build(deps): bump golang.org/x/net from 0.20.0 to 0.23.0
([#&#8203;1665](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1665))
- chore/nfd-master: remove warnings in nfd-master unit tests file
([#&#8203;1668](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1668))
- build(deps): bump golang.org/x/net from 0.20.0 to 0.23.0 in api/nfd
([#&#8203;1666](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1666))
- apis/nfd: add unit tests for match name functions
([#&#8203;1667](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1667))
- apis/nfd: no error on ops that never match
([#&#8203;1670](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1670))
- api/nfd: use varargs in the NewInstanceFeatures helper
([#&#8203;1669](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1669))
- scripts/test-infra: bump golangci-lint to v1.57.2
([#&#8203;1674](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1674))
- add ARMv7 support
([#&#8203;1659](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1659))
- docs: document trade-offs in memory configuration
([#&#8203;1651](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1651))
- go.mod: bump kubernetes to v1.30
([#&#8203;1675](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1675))
- cloudbuild.yaml: change machine type to e1-highcpu-32
([#&#8203;1678](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1678))
- test/e2e: stop importing kubernetes test/e2e
([#&#8203;1680](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1680))
- hack/init-buildx.sh: fix broken patter matching
([#&#8203;1683](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1683))
- Disable armv7 builds
([#&#8203;1677](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1677))
- cloudbuild.yaml: downgrade machine type to e2-highcpu-8
([#&#8203;1685](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1685))
- Update update_codegen.sh for v0.30 version of codegen tools
([#&#8203;1681](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1681))
- Dependabot: Add proper dependabot config file
([#&#8203;1679](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1679))
- build(deps): bump azure/setup-helm from 3 to 4
([#&#8203;1686](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1686))
- build(deps): bump actions/checkout from 1 to 4
([#&#8203;1687](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1687))
- build(deps): bump golang.org/x/net from 0.23.0 to 0.24.0
([#&#8203;1689](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1689))
- build(deps): bump sigs.k8s.io/yaml from 1.3.0 to 1.4.0
([#&#8203;1691](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1691))
- build(deps): bump github.com/onsi/gomega from 1.31.0 to 1.33.0
([#&#8203;1692](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1692))
- build(deps): bump github.com/onsi/ginkgo/v2 from 2.15.0 to 2.17.2
([#&#8203;1690](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1690))
- build(deps): bump github.com/jaypipes/ghw from
0.8.1-0.20210827132705-c7224150a17e to 0.12.0
([#&#8203;1688](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1688))
- apis/nfd: increase unit test coverage
([#&#8203;1693](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1693))
- build: specify buildx builder name everywhere
([#&#8203;1684](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1684))
- source/kernel: silence misleading error on selinux detection
([#&#8203;1694](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1694))
- build(deps): bump github.com/klauspost/cpuid/v2 from 2.2.6 to 2.2.7
([#&#8203;1695](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1695))
- build(deps): bump github.com/stretchr/testify from 1.8.4 to 1.9.0
([#&#8203;1696](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1696))
- build(deps): bump github.com/google/uuid from 1.5.0 to 1.6.0
([#&#8203;1698](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1698))
- build(deps): bump github.com/onsi/gomega from 1.33.0 to 1.33.1
([#&#8203;1699](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1699))
- build(deps): bump
github.com/k8stopologyawareschedwg/noderesourcetopology-api from 0.1.0
to 0.1.2
([#&#8203;1697](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1697))
- build(deps): bump golang.org/x/net from 0.24.0 to 0.25.0
([#&#8203;1701](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1701))
- build(deps): bump google.golang.org/grpc from 1.60.1 to 1.63.2
([#&#8203;1702](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1702))
- build(deps-dev): bump nokogiri from 1.16.2 to 1.16.5 in /docs
([#&#8203;1706](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1706))
- build(deps): bump google.golang.org/protobuf from 1.33.0 to 1.34.1
([#&#8203;1703](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1703))
- build(deps): bump github.com/k8stopologyawareschedwg/podfingerprint
from 0.1.2 to 0.2.2
([#&#8203;1705](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1705))
- nfd-master: add DisableAutoPrefix feature gate
([#&#8203;1707](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1707))
- Re-add -enable-nodefeature-api cmdline flag
([#&#8203;1708](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1708))
- build(deps): bump rexml from 3.2.6 to 3.2.8 in /docs
([#&#8203;1709](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1709))
- build(deps): bump github.com/onsi/ginkgo/v2 from 2.17.2 to 2.17.3
([#&#8203;1711](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1711))
- Add NodeFeatureGroup API
([#&#8203;1487](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1487))
- api/nfd: document all undocumented fields in the types
([#&#8203;1714](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1714))
- nfd-worker: improved log when creating NodeFeature object
([#&#8203;1713](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1713))
- apis/nfd: allow different types of features of the same name
([#&#8203;1671](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1671))
- cpu: advertise AVX10 version
([#&#8203;1673](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1673))
- source/cpu: disable AVX10 label
([#&#8203;1715](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1715))
- docs/helm: document all feature gates
([#&#8203;1716](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1716))
- build(deps): bump github.com/onsi/ginkgo/v2 from 2.17.3 to 2.19.0
([#&#8203;1717](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1717))
- docs: add more cross-references to NodeFeatureGroup API
([#&#8203;1718](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1718))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/lambchop4prez/network).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNzcuOCIsInVwZGF0ZWRJblZlciI6IjM3LjQyMS45IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
sp3nx0r pushed a commit to sp3nx0r/homelab that referenced this pull request Aug 3, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[node-feature-discovery](https://github.com/kubernetes-sigs/node-feature-discovery)
| patch | `0.16.0` -> `0.16.3` |

---

### Release Notes

<details>
<summary>kubernetes-sigs/node-feature-discovery
(node-feature-discovery)</summary>

###
[`v0.16.3`](https://github.com/kubernetes-sigs/node-feature-discovery/releases/tag/v0.16.3)

[Compare
Source](https://github.com/kubernetes-sigs/node-feature-discovery/compare/v0.16.2...v0.16.3)

Fix detection of swap in some scenarios
([#&#8203;1751](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1751))
and add Helm parameter to set the revisionHistoryLimit of nfd-master and
nfd-gc
([#&#8203;1759](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1759)).

**Full Changelog**:
kubernetes-sigs/node-feature-discovery@v0.16.2...v0.16.3

###
[`v0.16.2`](https://github.com/kubernetes-sigs/node-feature-discovery/releases/tag/v0.16.2)

[Compare
Source](https://github.com/kubernetes-sigs/node-feature-discovery/compare/v0.16.1...v0.16.2)

#### What's Changed

Fixes an issue where node labels were temporarily removed on nfd-worker
pod restarts.

**Full Changelog**:
kubernetes-sigs/node-feature-discovery@v0.16.1...v0.16.2

###
[`v0.16.1`](https://github.com/kubernetes-sigs/node-feature-discovery/releases/tag/v0.16.1)

[Compare
Source](https://github.com/kubernetes-sigs/node-feature-discovery/compare/v0.16.0...v0.16.1)

##### What's Changed

- \[release-0.16] Revert "build(deps): bump actions/checkout from 1 to
4" by
[@&#8203;k8s-infra-cherrypick-robot](https://github.com/k8s-infra-cherrypick-robot)
in
[kubernetes-sigs/node-feature-discovery#1721
- \[release-0.16] topology-updater: properly handle IPv6 from
NODE_ADDRESS by
[@&#8203;k8s-infra-cherrypick-robot](https://github.com/k8s-infra-cherrypick-robot)
in
[kubernetes-sigs/node-feature-discovery#1731
- \[release-0.16] helm: remove defaults CPU limits by
[@&#8203;k8s-infra-cherrypick-robot](https://github.com/k8s-infra-cherrypick-robot)
in
[kubernetes-sigs/node-feature-discovery#1736
- \[release-0.16] Fix the problem with starting the master with empty
cache by
[@&#8203;k8s-infra-cherrypick-robot](https://github.com/k8s-infra-cherrypick-robot)
in
[kubernetes-sigs/node-feature-discovery#1740
- \[release-0.16] ensure post-delete-job's service account matches ref
in job spec by
[@&#8203;k8s-infra-cherrypick-robot](https://github.com/k8s-infra-cherrypick-robot)
in
[kubernetes-sigs/node-feature-discovery#1750

**Full Changelog**:
kubernetes-sigs/node-feature-discovery@v0.16.0...v0.16.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on saturday" (UTC), Automerge - At
any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job log](https://developer.mend.io/github/sp3nx0r/homelab).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjEuOSIsInVwZGF0ZWRJblZlciI6IjM3LjQzOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9oZWxtIiwidHlwZS9wYXRjaCJdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants