Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scripts: refresh e2e-presubmit test script #1758

Merged
merged 1 commit into from
Jul 8, 2024
Merged

scripts: refresh e2e-presubmit test script #1758

merged 1 commit into from
Jul 8, 2024

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Jul 5, 2024

Update and simplify.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 5, 2024
@marquiz
Copy link
Contributor Author

marquiz commented Jul 5, 2024

/assign @ArangoGutierrez

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 5, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 5, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit fb2b192
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/6687de3c244812000837b3da
😎 Deploy Preview https://deploy-preview-1758--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ArangoGutierrez
Copy link
Contributor

/test all

@ArangoGutierrez
Copy link
Contributor

/test all

@ArangoGutierrez
Copy link
Contributor

/test all

@marquiz
Copy link
Contributor Author

marquiz commented Jul 5, 2024

/test pull-node-feature-discovery-e2e-test-master

1 similar comment
@marquiz
Copy link
Contributor Author

marquiz commented Jul 5, 2024

/test pull-node-feature-discovery-e2e-test-master

@marquiz
Copy link
Contributor Author

marquiz commented Jul 5, 2024

/test pull-node-feature-discovery-verify-master

@marquiz
Copy link
Contributor Author

marquiz commented Jul 5, 2024

/retest

This was referenced Jul 5, 2024
Merged
Merged
@ArangoGutierrez
Copy link
Contributor

/test pull-node-feature-discovery-verify-master

1 similar comment
@ArangoGutierrez
Copy link
Contributor

/test pull-node-feature-discovery-verify-master

@marquiz
Copy link
Contributor Author

marquiz commented Jul 5, 2024

/retest

ArangoGutierrez
ArangoGutierrez approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 8, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ArangoGutierrez,marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 261b5a0cd9b88c89ec7cdc743c5d7cb9bc7d0e21

@k8s-ci-robot k8s-ci-robot merged commit dcc03a6 into kubernetes-sigs:master Jul 8, 2024
11 checks passed
@marquiz marquiz deleted the devel/e2e-presubmit branch July 8, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArangoGutierrez ArangoGutierrez ArangoGutierrez approved these changes

@fmuyassarov fmuyassarov Awaiting requested review from fmuyassarov

@jjacobelli jjacobelli Awaiting requested review from jjacobelli

Assignees

@ArangoGutierrez ArangoGutierrez

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marquiz @ArangoGutierrez @k8s-ci-robot