Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop the -enable-nodefeature-api flag #1780

Merged

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Jul 10, 2024

Was marked to be removed in v0.17.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 10, 2024
Copy link

netlify bot commented Jul 10, 2024

Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit a269bf4
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/668e7c828440280008725e41
😎 Deploy Preview https://deploy-preview-1780--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@marquiz
Copy link
Contributor Author

marquiz commented Jul 10, 2024

/assign @ArangoGutierrez

@marquiz marquiz mentioned this pull request Jul 10, 2024
10 tasks
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 10, 2024
Was marked to be removed in v0.17.
@marquiz
Copy link
Contributor Author

marquiz commented Jul 10, 2024

I hope I now catched everything in the latest version of the PR

Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 11, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ArangoGutierrez,marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6317bae953d8d88231603799e37da52b16ef1e93

@k8s-ci-robot k8s-ci-robot merged commit ee7795c into kubernetes-sigs:master Jul 11, 2024
12 checks passed
@marquiz marquiz deleted the devel/nodefeatureapi-flag branch July 12, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants