Implement helm add & install in helm e2e test #1803

THUzxj · 2024-07-20T14:09:22Z

Hi,

for adding helm e2e tests discussed in #1769, I have implemented helm add repo, and install chart. The helm API is from e2e-framework. I would appreciate it if you could review the implementation for further development.

And for our future plan:

Which components should we verify for successfully deployed by helm? For example, service and pods?
Which existing test cases can be integrated into helm e2e tests?

Additionally, I encountered an error stating:

"seccompProfile (pod or container must set securityContext.seccompProfile.type to "RuntimeDefault" or "Localhost")"

when running helm install via the code, despite the command working fine when executed manually in the terminal. As a workaround, I added f.NamespacePodSecurityEnforceLevel = admissionapi.LevelBaseline. I'm uncertain if this is the correct approach. Do you have any suggestions or improvements for this issue?

Thank you very much!

k8s-ci-robot · 2024-07-20T14:09:32Z

Welcome @THUzxj!

It looks like this is your first PR to kubernetes-sigs/node-feature-discovery 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/node-feature-discovery has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2024-07-20T14:09:32Z

Hi @THUzxj. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

netlify · 2024-07-20T14:09:40Z

❌ Deploy Preview for kubernetes-sigs-nfd failed. Why did it fail? →

Name	Link
🔨 Latest commit	`a18ce34`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/66bd7b0e39bd1e0008df8aae

ArangoGutierrez · 2024-07-22T09:09:30Z

/assign @marquiz

ArangoGutierrez · 2024-07-22T09:09:53Z

/assign

test/e2e/helm_test.go

ArangoGutierrez · 2024-07-22T09:13:07Z

test/e2e/helm_test.go

+	"k8s.io/kubernetes/test/e2e/framework"
+	"sigs.k8s.io/e2e-framework/third_party/helm"
+
+	// e2enetwork "k8s.io/kubernetes/test/e2e/framework/network"


ArangoGutierrez · 2024-07-22T09:13:25Z

test/e2e/helm_test.go

+	admissionapi "k8s.io/pod-security-admission/api"
+)
+
+// Actual test suite


Helm based test suite

ArangoGutierrez · 2024-07-22T09:19:25Z

test/e2e/helm_test.go

+	chart_name := "nfd/node-feature-discovery"
+	release_name := "node-feature-discovery"
+	version := "0.16.3"
+


We should test local helm charts, instead of released ones, this way we can tests if current changes will break Helm deployment

ArangoGutierrez · 2024-07-22T09:19:39Z

test/e2e/helm_test.go

+	version := "0.16.3"
+
+	Context("when deploying by helm", Ordered, func() {
+


trailing extra line

ArangoGutierrez · 2024-07-22T09:19:45Z

test/e2e/helm_test.go

+			// manager := helm.New(framework.TestContext.KubeConfig)
+			// err := manager.RunRepo(helm.WithArgs("remove", "nfd"))
+			// Expect(err).NotTo(HaveOccurred())


ArangoGutierrez · 2024-07-22T09:19:51Z

test/e2e/helm_test.go

+			// Error: error waiting for service node-feature-discovery-xxxx/ to appear: resource name may not be empty
+			// By("Waiting for the nfd-master service to be up")
+			// nfdSvc, err := f.ClientSet.CoreV1().Services(f.Namespace.Name).Get(ctx, "nfd-master", v1.GetOptions{})
+			// Expect(e2enetwork.WaitForService(ctx, f.ClientSet, f.Namespace.Name, nfdSvc.Name, true, time.Second, 10*time.Second)).NotTo(HaveOccurred())


ArangoGutierrez · 2024-07-22T09:20:15Z

test/e2e/helm_test.go

+			Expect(err).NotTo(HaveOccurred())
+		})
+
+		//


If we are adding comments here, we should comment each step also

@THUzxj please address this comment

Sorry maybe I don't fully understand "comment each step", so I just removed this comment

k8s-ci-robot · 2024-07-22T09:20:24Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: THUzxj
Once this PR has been reviewed and has the lgtm label, please ask for approval from arangogutierrez. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

THUzxj · 2024-07-22T09:41:56Z

@ArangoGutierrez Thanks for your review. I will fix the code soon.

ArangoGutierrez · 2024-07-29T09:53:34Z

@ArangoGutierrez Thanks for your review. I will fix the code soon.

Hey @THUzxj how's this going, ping me if you need any help

THUzxj · 2024-07-29T10:21:48Z

@ArangoGutierrez Thanks for your review. I will fix the code soon.

Hey @THUzxj how's this going, ping me if you need any help

Sorry that I am not familiar with the review process. I have fixed your comments and maybe you could review it again.

ArangoGutierrez · 2024-08-12T09:15:55Z

@THUzxj

They @THUzxj sorry for the delay, been busy on the day job, will review this this week

ArangoGutierrez · 2024-08-12T09:17:38Z

test/e2e/helm_test.go

+			workingDir, err := os.Getwd()
+			chartPath := filepath.Join(workingDir, "../../", "deployment", "helm", "node-feature-discovery")
+			Expect(err).NotTo(HaveOccurred())
+			By("helm install " + release_name + " " + chartPath + " --namespace " + f.Namespace.Name + " --wait")


https://onsi.github.io/ginkgo/#documenting-complex-specs-by

Let's re write this "By"

ArangoGutierrez · 2024-08-12T09:18:36Z

test/e2e/helm_test.go

+			Expect(err).NotTo(HaveOccurred())
+		})
+
+		//


@THUzxj please address this comment

k8s-ci-robot requested review from adrianchiris and TessaIO July 20, 2024 14:09

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 20, 2024

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 20, 2024

k8s-ci-robot assigned marquiz Jul 22, 2024

k8s-ci-robot assigned ArangoGutierrez Jul 22, 2024

ArangoGutierrez requested changes Jul 22, 2024

View reviewed changes

THUzxj force-pushed the helm branch 3 times, most recently from 4859578 to f0ae10e Compare July 22, 2024 16:30

THUzxj force-pushed the helm branch from f0ae10e to adaeafa Compare July 29, 2024 10:20

THUzxj requested a review from ArangoGutierrez July 29, 2024 10:21

ArangoGutierrez requested changes Aug 12, 2024

View reviewed changes

Implement helm add & install in helm e2e test

a18ce34

THUzxj force-pushed the helm branch from adaeafa to a18ce34 Compare August 15, 2024 03:50

THUzxj requested a review from ArangoGutierrez August 15, 2024 04:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement helm add & install in helm e2e test #1803

Implement helm add & install in helm e2e test #1803

THUzxj commented Jul 20, 2024

k8s-ci-robot commented Jul 20, 2024

k8s-ci-robot commented Jul 20, 2024

netlify bot commented Jul 20, 2024 •

edited

Loading

ArangoGutierrez commented Jul 22, 2024

ArangoGutierrez commented Jul 22, 2024

ArangoGutierrez Jul 22, 2024

ArangoGutierrez Jul 22, 2024

ArangoGutierrez Jul 22, 2024

ArangoGutierrez Jul 22, 2024

ArangoGutierrez Jul 22, 2024

ArangoGutierrez Jul 22, 2024

ArangoGutierrez Jul 22, 2024

ArangoGutierrez Aug 12, 2024

THUzxj Aug 15, 2024

k8s-ci-robot commented Jul 22, 2024

THUzxj commented Jul 22, 2024

ArangoGutierrez commented Jul 29, 2024

THUzxj commented Jul 29, 2024

ArangoGutierrez commented Aug 12, 2024

ArangoGutierrez Aug 12, 2024

THUzxj Aug 15, 2024

ArangoGutierrez Aug 12, 2024

		version := "0.16.3"

		Context("when deploying by helm", Ordered, func() {

Implement helm add & install in helm e2e test #1803

Are you sure you want to change the base?

Implement helm add & install in helm e2e test #1803

Conversation

THUzxj commented Jul 20, 2024

k8s-ci-robot commented Jul 20, 2024

k8s-ci-robot commented Jul 20, 2024

netlify bot commented Jul 20, 2024 • edited Loading

❌ Deploy Preview for kubernetes-sigs-nfd failed. Why did it fail? →

ArangoGutierrez commented Jul 22, 2024

ArangoGutierrez commented Jul 22, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

k8s-ci-robot commented Jul 22, 2024

THUzxj commented Jul 22, 2024

ArangoGutierrez commented Jul 29, 2024

THUzxj commented Jul 29, 2024

ArangoGutierrez commented Aug 12, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

netlify bot commented Jul 20, 2024 •

edited

Loading