Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add helm migration guide #1807

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Add helm migration guide #1807

merged 1 commit into from
Aug 5, 2024

Conversation

ArangoGutierrez
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 23, 2024
@ArangoGutierrez
Copy link
Contributor Author

/assign @marquiz

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 23, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 23, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit cb53f9f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/669fbc4c1a899d00087f782b
😎 Deploy Preview https://deploy-preview-1807--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@marquiz
Copy link
Contributor

marquiz commented Jul 23, 2024

/cherry-pick release-0.16

@k8s-infra-cherrypick-robot
Copy link

@marquiz: once the present PR merges, I will cherry-pick it on top of release-0.16 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ArangoGutierrez ArangoGutierrez mentioned this pull request Jul 23, 2024
Open
marquiz
marquiz reviewed Jul 23, 2024
View reviewed changes
docs/deployment/helm.md Outdated Show resolved Hide resolved
docs/deployment/helm.md Outdated Show resolved Hide resolved
docs/deployment/helm.md Outdated Show resolved Hide resolved
docs/deployment/helm.md Outdated Show resolved Hide resolved
docs/deployment/helm.md Outdated Show resolved Hide resolved
docs/deployment/helm.md Outdated Show resolved Hide resolved
docs/deployment/helm.md Show resolved Hide resolved
docs/deployment/helm.md Outdated Show resolved Hide resolved
docs/deployment/helm.md Outdated Show resolved Hide resolved
docs/deployment/helm.md Outdated Show resolved Hide resolved
@marquiz marquiz mentioned this pull request Jul 23, 2024
Open
marquiz
marquiz reviewed Jul 23, 2024
View reviewed changes
docs/deployment/helm.md Outdated Show resolved Hide resolved
docs/deployment/helm.md Outdated Show resolved Hide resolved
@marquiz
Copy link
Contributor

marquiz commented Jul 23, 2024

@ahmetb PTAL
/assign @adrianchiris

@ArangoGutierrez
Add helm migration guide
cb53f9f 
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
adrianchiris
adrianchiris reviewed Aug 4, 2024
View reviewed changes
docs/deployment/helm.md Show resolved Hide resolved
docs/deployment/helm.md Show resolved Hide resolved
adrianchiris
adrianchiris approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@adrianchiris adrianchiris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1740ed08aeb5dfd84c1b57c029d594f5a6b482a0

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianchiris, ArangoGutierrez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8ffe9f9 into kubernetes-sigs:master Aug 5, 2024
8 checks passed
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Aug 5, 2024
Merged
@k8s-infra-cherrypick-robot
Copy link

@marquiz: new pull request created: #1825

In response to this:

/cherry-pick release-0.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianchiris adrianchiris adrianchiris approved these changes

@fmuyassarov fmuyassarov Awaiting requested review from fmuyassarov

@zvonkok zvonkok Awaiting requested review from zvonkok

@marquiz marquiz Awaiting requested review from marquiz

Assignees

@marquiz marquiz

@adrianchiris adrianchiris

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ArangoGutierrez @marquiz @k8s-infra-cherrypick-robot @k8s-ci-robot @adrianchiris