-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nfd-master: tweak list options for NodeFeature informer #1811
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -29,6 +29,7 @@ import ( | |
nfdclientset "sigs.k8s.io/node-feature-discovery/api/generated/clientset/versioned" | ||
nfdscheme "sigs.k8s.io/node-feature-discovery/api/generated/clientset/versioned/scheme" | ||
nfdinformers "sigs.k8s.io/node-feature-discovery/api/generated/informers/externalversions" | ||
nfdinformersv1alpha1 "sigs.k8s.io/node-feature-discovery/api/generated/informers/externalversions/nfd/v1alpha1" | ||
nfdlisters "sigs.k8s.io/node-feature-discovery/api/generated/listers/nfd/v1alpha1" | ||
nfdv1alpha1 "sigs.k8s.io/node-feature-discovery/api/nfd/v1alpha1" | ||
"sigs.k8s.io/node-feature-discovery/pkg/utils" | ||
|
@@ -67,13 +68,23 @@ func newNfdController(config *restclient.Config, nfdApiControllerOptions nfdApiC | |
} | ||
|
||
nfdClient := nfdclientset.NewForConfigOrDie(config) | ||
|
||
klog.V(2).InfoS("initializing new NFD API controller", "options", utils.DelayedDumper(nfdApiControllerOptions)) | ||
|
||
informerFactory := nfdinformers.NewSharedInformerFactory(nfdClient, nfdApiControllerOptions.ResyncPeriod) | ||
|
||
// Add informer for NodeFeature objects | ||
if !nfdApiControllerOptions.DisableNodeFeature { | ||
featureInformer := informerFactory.Nfd().V1alpha1().NodeFeatures() | ||
tweakListOpts := func(opts *metav1.ListOptions) { | ||
// Tweak list opts on initial sync to avoid timeouts on the apiserver. | ||
// NodeFeature objects are huge and the Kubernetes apiserver | ||
// (v1.30) experiences http handler timeouts when the resource | ||
// version is set to some non-empty value (TODO: find out why). | ||
if opts.ResourceVersion == "0" { | ||
opts.ResourceVersion = "" | ||
} | ||
} | ||
featureInformer := nfdinformersv1alpha1.New(informerFactory, "", tweakListOpts).NodeFeatures() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Q: doesn't nfd-gc need this tweak too? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Indeed, needed there! I will update There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
if _, err := featureInformer.Informer().AddEventHandler(cache.ResourceEventHandlerFuncs{ | ||
AddFunc: func(obj interface{}) { | ||
nfr := obj.(*nfdv1alpha1.NodeFeature) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't happen as we basically only set rv="" on the initial LIST operation. When setting up the watches RV is always set >0