docs: use jekyll-rtd-theme from a ruby gem #1829
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
✅ Deploy Preview for kubernetes-sigs-nfd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/assign @fmuyassarov @ArangoGutierrez |
|
@marquiz: once the present PR merges, I will cherry-pick it on top of release-0.16 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
marquiz
force-pushed
the
devel/docs-theme
branch
6 times, most recently
from
808c225
to
ea8205c
Compare
k8s-ci-robot
added
size/M
marquiz
force-pushed
the
devel/docs-theme
branch
from
ea8205c
to
a88ee74
Compare
k8s-ci-robot
added
size/S
marquiz
force-pushed
the
devel/docs-theme
branch
from
be77ca8
to
a65e828
Compare
k8s-ci-robot
added
size/M
marquiz
force-pushed
the
devel/docs-theme
branch
2 times, most recently
from
fbcffb5
to
c91b0dc
Compare
k8s-ci-robot
added
size/S
marquiz
force-pushed
the
devel/docs-theme
branch
from
0c61d1d
to
595df2f
Compare
marquiz
force-pushed
the
devel/docs-theme
branch
from
f44412d
to
6864a92
Compare
The upstream repo (and the release downloads) github.com/rundocs/jekyll-rtd-theme has been deleted. This broke our docs generation as the remote theme configuration depended on downloading the release artefact. This patch changes the docs building to use a Ruby gem instead of the remote theme setting. To complicate matters, the gem has an seemingly incorrect (too strict) version dependency. To mitigate this, we now install bundler-override plugin to ignore this particular dependency. The netlify conf is a hack, but I wasn't able to figure out a way how to install the bundler-override plugin without doing all ruby initialization in the build command.
marquiz
force-pushed
the
devel/docs-theme
branch
from
6864a92
to
b2bc18f
Compare
|
Finally I was able to make the netlify conf work. @ArangoGutierrez @fmuyassarov PTAL |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 2245fc6373a9de49db43654d728331d3b62eccb1
|
|
@marquiz: new pull request created: #1830 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The upstream repo (and the release downloads)
github.com/rundocs/jekyll-rtd-theme has been deleted. This broke our docs generation as the remote theme configuration depended on downloading the release artefact.
This patch changes the docs building to use a Ruby gem instead of the remote theme setting. To complicate matters, the gem has an seemingly incorrect (too strict) version dependency. To mitigate this, we now install bundler-override plugin to ignore this particular dependency.