-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nfd-worker: Add an option to disable setting the owner references #1860
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ozhuraki The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @ozhuraki. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-sigs-nfd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
In some cases it's desirable to control automatic garbage collection of NodeFeature object. Add an option to disable setting the owner references to Pod for NodeFeature object. Closes: 1817 Signed-off-by: Oleg Zhurakivskyy <oleg.zhurakivskyy@intel.com>
f825f86
to
6b8f9c5
Compare
Setting `core.noOwnerRefs` to `true` disables setting the owner references | ||
to Pod for NodeFeature object. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ozhuraki for the improvement! Just one nit about the wording (we don't just mark to pod as the owner but also the parent owner of the pod). E.g.
Setting `core.noOwnerRefs` to `true` disables setting the owner references | |
to Pod for NodeFeature object. | |
Setting `core.noOwnerRefs` to `true` disables setting the owner references | |
of the NodeFeature object created by the nfd-worker. |
Ditto the cmdline reference
/ok-to-test |
In some cases it's desirable to control automatic garbage collection of NodeFeature object.
Add an option to disable setting the owner references to Pod for NodeFeature object.
Closes: #1817