Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Go to 1.18 #785

Merged
merged 2 commits into from
Apr 14, 2022
Merged

Bump Go to 1.18 #785

merged 2 commits into from
Apr 14, 2022

Conversation

ArangoGutierrez
Copy link
Contributor

Signed-off-by: Carlos Eduardo Arango Gutierrez carangog@redhat.com

@ArangoGutierrez
Copy link
Contributor Author

ArangoGutierrez commented Mar 16, 2022 •
edited
Loading

Hold on after -> kubernetes/test-infra#25651

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 16, 2022
@ArangoGutierrez
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 16, 2022
@ArangoGutierrez
Copy link
Contributor Author

golangci-lint@1.45 now supports go1.18 we are good to review this
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 18, 2022
marquiz
marquiz reviewed Mar 21, 2022
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@ArangoGutierrez
Bump Go to 1.18
87b29f6 
Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 21, 2022
@ArangoGutierrez
Copy link
Contributor Author

Test-infra pair -> kubernetes/test-infra#25651

@ArangoGutierrez
Copy link
Contributor Author

@marquiz can this make it to v0.11? or defer?

@marquiz
Copy link
Contributor

marquiz commented Mar 28, 2022

@marquiz can this make it to v0.11? or defer?

I suggest to defer to minimize risks and hassle on that front

@ArangoGutierrez
Copy link
Contributor Author

@marquiz can this make it to v0.11? or defer?

I suggest to defer to minimize risks and hassle on that front

v0.11 is cut, we can circle back to this

marquiz
marquiz reviewed Apr 12, 2022
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
@ArangoGutierrez @marquiz
Update Dockerfile
71c0ab1 
Co-authored-by: Markus Lehtonen <markus.lehtonen@intel.com>
marquiz
marquiz approved these changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ArangoGutierrez, looks good 👍

Let's wait for kubernetes/test-infra#25651 to land first.
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 12, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2022
@marquiz
Copy link
Contributor

marquiz commented Apr 13, 2022

/test all

@marquiz
Copy link
Contributor

marquiz commented Apr 13, 2022

/retest
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 13, 2022
@marquiz
Copy link
Contributor

marquiz commented Apr 14, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 14, 2022
@kad
Copy link
Contributor

kad commented Apr 14, 2022

You need to make sure that 1.18.1+ is used. 1.18.0 had regression in PEM certificates handling which was fixed very recently.

@marquiz
Copy link
Contributor

marquiz commented Apr 14, 2022

You need to make sure that 1.18.1+ is used. 1.18.0 had regression in PEM certificates handling which was fixed very recently.

Yeah. Looks like the docker images were also published a few hours ago

@marquiz
Copy link
Contributor

marquiz commented Apr 14, 2022

/test all

@k8s-ci-robot k8s-ci-robot merged commit e475390 into kubernetes-sigs:master Apr 14, 2022
@marquiz marquiz mentioned this pull request Dec 20, 2022
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marquiz marquiz marquiz approved these changes

@jjacobelli jjacobelli Awaiting requested review from jjacobelli

@kad kad Awaiting requested review from kad

Assignees

@marquiz marquiz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ArangoGutierrez @marquiz @k8s-ci-robot @kad