-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cpu: add cpuid stub for non-linux platforms #808
Conversation
Make it possible to do non-linux builds. Code compiles, at least, even if the feature detection functionality is virtually Linux-only.
Skipping CI for Draft Pull Request. |
0eb044c
to
d50797c
Compare
@mathuvenkat can you verify/confirm that this fixes your issue (on darwin/arm64). |
I have 2 Linux machines at home ;P , going to ask for a friend to test this out on Mac and report back later this week |
@ArangoGutierrez In node-feature-discovery/bin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ArangoGutierrez, marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @ArangoGutierrez |
Make it possible to do non-linux builds. Code compiles, at least, even
if the feature detection functionality is virtually Linux-only.