Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github: small fix in new-release issue template #822

Merged
merged 1 commit into from
Jun 8, 2022
Merged

github: small fix in new-release issue template #822

merged 1 commit into from
Jun 8, 2022

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Jun 7, 2022

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 7, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2022
@marquiz
Copy link
Contributor Author

marquiz commented Jun 7, 2022

/assign @ArangoGutierrez

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 7, 2022
ArangoGutierrez
ArangoGutierrez requested changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we will hopefully soon talk about 1.x, so I am not sold into hardcoding it like 0.major right?

@marquiz
Copy link
Contributor Author

marquiz commented Jun 7, 2022

0.$MAJ is used elsewhere in this template so I'd suggest to use it for now. Let's update the template if we ever get to 1.0 😎 Looking at the pace of improvements/contributions of the past few months we're not reaching 1.0 anytime soon...

@marquiz
Copy link
Contributor Author

marquiz commented Jun 8, 2022

/retest

ArangoGutierrez
ArangoGutierrez approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 8, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3b4c1b1 into kubernetes-sigs:master Jun 8, 2022
@marquiz marquiz deleted the fixes/github branch June 13, 2022 06:23
@marquiz marquiz mentioned this pull request Dec 20, 2022
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArangoGutierrez ArangoGutierrez ArangoGutierrez approved these changes

@adrianchiris adrianchiris Awaiting requested review from adrianchiris

@zvonkok zvonkok Awaiting requested review from zvonkok

Assignees

@ArangoGutierrez ArangoGutierrez

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marquiz @k8s-ci-robot @ArangoGutierrez