cpu: Discover Intel TDX #830

fidencio · 2022-06-17T15:27:42Z

Set cpu.tdx-enable to true when TDX is avialable and has been
enabled.

/sys/module/kvm_intel/parameters/tdx presence and content is used to
detect whether a CPU is Intel TDX capable.

Signed-off-by: Fabiano Fidêncio fabiano.fidencio@intel.com

linux-foundation-easycla · 2022-06-17T15:27:46Z

The committers listed above are authorized under a signed CLA.

✅ login: fidencio / name: Fabiano Fidêncio (ac9f6de)

k8s-ci-robot · 2022-06-17T15:27:50Z

Welcome @fidencio!

It looks like this is your first PR to kubernetes-sigs/node-feature-discovery 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/node-feature-discovery has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2022-06-17T15:27:51Z

Hi @fidencio. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

zvonkok · 2022-06-20T07:49:10Z

/ok-to-test

zvonkok · 2022-06-20T07:49:41Z

/assign

zvonkok · 2022-06-20T07:52:36Z

LGTM @marquiz PTAL /cc @mythi

zvonkok · 2022-06-20T07:54:17Z

/lgtm

mythi

LGTM,

one small typo

docs/get-started/features.md

zvonkok · 2022-06-22T14:18:49Z

/lgtm

ArangoGutierrez

/lgtm

marquiz · 2022-06-27T14:14:44Z

Thanks @fidencio for the PR and sorry for the silence 😇 I think this PR basically looks good when looking at it in isolation. However, in broader perspective I'm growing nervous about the organization of all the somewhat cluttered features regarding security/trusted-execution. No need to solve it as part of this PR, though 😊

I created #832 to track the "re-organization issue". I'd really want to get that resolved before the next release. In terms of code it's not a huge deal (if we decide to do that) but I'd definitely like to hear your opinion on that.

What it comes to this PR (#830), I'd prolly keep it open for now, just to incentivize us to get #832 resolved (sorry about that 🙄)

zvonkok · 2022-06-28T09:17:02Z

@marquiz Agree, see my comment on #790 (comment) enabling PEF for Power. We need to come up with more structure, especially when starting to add ARM CCA and AMD SNP support :) Especially SNP has some sub-features that will extend the list of labels quite a lot.

marquiz · 2022-09-01T13:01:38Z

@fidencio now that #833 is merged you whould rebase this one and I think it could be merged (after review 😊)

source/cpu/security_amd64.go

marquiz

Thanks @fidencio for working on this. Took a bit longer than expected because of the "security label resuffling" 😊 But now I think we could get this in

mythi · 2022-10-03T07:40:21Z

docs/advanced/customization-guide.md

@@ -491,6 +491,7 @@ The following features are available for matching:
 | **`cpu.security`** | attribute  |          |            | Features related to security and trusted execution environments
 |                  |              | **`sgx.enabled`** | bool | `true` if Intel SGX (Software Guard Extensions) has been enabled, otherwise does not exist
 |                  |              | **`se.enabled`** | bool  | `true` if IBM Secure Execution for Linux is available and has been enabled, otherwise does not exist
+|                  |              | **`tdx.enabled`** | bool | `true` if Intel TDX (Trusted Domain Extensions) is available and has been enabled, otherwise does not exist


while this follows how it's written for se.enabled, I think it'd be good to clarify this label is available on the host and not that it's a "node is a TD":

Suggested change

| | | **`tdx.enabled`** | bool | `true` if Intel TDX (Trusted Domain Extensions) is available and has been enabled, otherwise does not exist

| | | **`tdx.enabled`** | bool | `true` if Intel TDX (Trusted Domain Extensions) is available on the host and has been enabled, otherwise does not exist

ditto for features.md.

Set `cpu-security.tdx.enable` to `true` when TDX is avialable and has been enabled. otherwise it'll be set to `false`. `/sys/module/kvm_intel/parameters/tdx` presence and content is used to detect whether a CPU is Intel TDX capable. Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com>

mythi

LGTM, thanks @fidencio

marquiz

/lgtm

k8s-ci-robot · 2022-10-03T09:26:15Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, fidencio, marquiz, mythi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

fidencio · 2022-10-03T10:15:40Z

/retest

marquiz · 2022-10-03T10:16:10Z

/retest

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 17, 2022

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 17, 2022

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 17, 2022

k8s-ci-robot requested review from adrianchiris and ArangoGutierrez June 17, 2022 15:27

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 17, 2022

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 20, 2022

k8s-ci-robot assigned zvonkok Jun 20, 2022

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2022

mythi approved these changes Jun 22, 2022

View reviewed changes

mythi reviewed Jun 22, 2022

View reviewed changes

docs/get-started/features.md Outdated Show resolved Hide resolved

fidencio force-pushed the topic/discover-intel-tdx branch from ac9f6de to dd5e28e Compare June 22, 2022 12:40

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 22, 2022

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 22, 2022

ArangoGutierrez approved these changes Jun 22, 2022

View reviewed changes

k8s-ci-robot assigned ArangoGutierrez Jun 22, 2022

marquiz mentioned this pull request Jun 27, 2022

Re-organize security related features #832

Closed

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 1, 2022

fidencio force-pushed the topic/discover-intel-tdx branch from dd5e28e to e282ed2 Compare September 2, 2022 10:21

fidencio force-pushed the topic/discover-intel-tdx branch from e282ed2 to 78f3ae0 Compare September 2, 2022 10:24

marquiz reviewed Sep 6, 2022

View reviewed changes

source/cpu/security_amd64.go Show resolved Hide resolved

marquiz approved these changes Sep 6, 2022

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2022

mythi reviewed Oct 3, 2022

View reviewed changes

fidencio force-pushed the topic/discover-intel-tdx branch from 78f3ae0 to d5db1cf Compare October 3, 2022 07:56

mythi approved these changes Oct 3, 2022

View reviewed changes

marquiz approved these changes Oct 3, 2022

View reviewed changes

k8s-ci-robot assigned marquiz Oct 3, 2022

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 3, 2022

k8s-ci-robot merged commit 6071927 into kubernetes-sigs:master Oct 3, 2022

marquiz mentioned this pull request Dec 20, 2022

Release v0.12.0 #985

Closed

22 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cpu: Discover Intel TDX #830

cpu: Discover Intel TDX #830

fidencio commented Jun 17, 2022

linux-foundation-easycla bot commented Jun 17, 2022 •

edited

Loading

k8s-ci-robot commented Jun 17, 2022

k8s-ci-robot commented Jun 17, 2022

zvonkok commented Jun 20, 2022

zvonkok commented Jun 20, 2022

zvonkok commented Jun 20, 2022

zvonkok commented Jun 20, 2022

mythi left a comment

zvonkok commented Jun 22, 2022

ArangoGutierrez left a comment

marquiz commented Jun 27, 2022

zvonkok commented Jun 28, 2022 •

edited

Loading

marquiz commented Sep 1, 2022

marquiz left a comment

mythi Oct 3, 2022

mythi left a comment

marquiz left a comment

k8s-ci-robot commented Oct 3, 2022

fidencio commented Oct 3, 2022

marquiz commented Oct 3, 2022

	\| \| \| `tdx.enabled` \| bool \| `true` if Intel TDX (Trusted Domain Extensions) is available and has been enabled, otherwise does not exist
	\| \| \| `tdx.enabled` \| bool \| `true` if Intel TDX (Trusted Domain Extensions) is available on the host and has been enabled, otherwise does not exist

cpu: Discover Intel TDX #830

cpu: Discover Intel TDX #830

Conversation

fidencio commented Jun 17, 2022

linux-foundation-easycla bot commented Jun 17, 2022 • edited Loading

k8s-ci-robot commented Jun 17, 2022

k8s-ci-robot commented Jun 17, 2022

zvonkok commented Jun 20, 2022

zvonkok commented Jun 20, 2022

zvonkok commented Jun 20, 2022

zvonkok commented Jun 20, 2022

mythi left a comment

Choose a reason for hiding this comment

zvonkok commented Jun 22, 2022

ArangoGutierrez left a comment

Choose a reason for hiding this comment

marquiz commented Jun 27, 2022

zvonkok commented Jun 28, 2022 • edited Loading

marquiz commented Sep 1, 2022

marquiz left a comment

Choose a reason for hiding this comment

mythi Oct 3, 2022

Choose a reason for hiding this comment

mythi left a comment

Choose a reason for hiding this comment

marquiz left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Oct 3, 2022

fidencio commented Oct 3, 2022

marquiz commented Oct 3, 2022

linux-foundation-easycla bot commented Jun 17, 2022 •

edited

Loading

zvonkok commented Jun 28, 2022 •

edited

Loading