helm: add namespace override for multi-namespace deployments

[jasine]

when use this helm chart as other charts' dependency(Helm Dependency), helm will install manifests of this chart to parent chart's namespace, because .Release.Namespace is parent chart's namespace. so, if we want this chart installed to a separated namespace, community of helm project recommend add namespaceOverride (helm/charts#15202), and namespaceOverride is in helm template chart by default now.

many helm charts support namespaceOverride, such as kube-prometheus-stack

[k8s-ci-robot]

Welcome @jasine!

It looks like this is your first PR to kubernetes-sigs/node-feature-discovery 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/node-feature-discovery has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @jasine. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[marquiz]

Thanks @jasine for the patch! Looks pretty straightforward to me 👍

Just one small nit about the commit message, I didn't get what feat refers to 😊 I'd suggest to change the topic to e.g. helm

helm: add namespace override for multi-namespace deployments

/ok-to-test

[marquiz]

Just one small nit about the commit message, I didn't get what feat refers to 😊 I'd suggest to change the topic to e.g. helm

Oh, and one more thing about the commit message: you could add the description of this PR in the commit message, too (just start sentences with a Capital letter). We rarely have too long and descriptive commit messages 😉

[jasine]

Just one small nit about the commit message, I didn't get what feat refers to 😊 I'd suggest to change the topic to e.g. helm

Oh, and one more thing about the commit message: you could add the description of this PR in the commit message, too (just start sentences with a Capital letter). We rarely have too long and descriptive commit messages 😉

@marquiz thanks for your advice, I have changed the commit message and description

[marquiz]

Thanks for the update and nice contribution @jasine. I think this is good to go

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasine, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[marquiz]

/assign @adrianchiris
/cc @eliaskoromilas

[k8s-ci-robot]

@marquiz: GitHub didn't allow me to request PR reviews from the following users: eliaskoromilas.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/assign @adrianchiris
/cc @eliaskoromilas

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[eliaskoromilas]

Generally, it's not the best practice to escape the Helm namespace. I'm not against providing this as an option though!

What I like in this PR is that finally metadata.namespace is explicitly specified in every resource. Since the release namespace is already being referenced in some templates, it makes more sense to have it everywhere (e.g. when you just execute the chart templates with helm template).

[jasine]

is there anything I can do to help merging this pr @marquiz

[marquiz]

is there anything I can do to help merging this pr @marquiz

Sorry for the silence. Just back from a long summer holiday...

Thanks for the comment @eliaskoromilas! I take that as a lgtm(?) (at least a weak signal 😄).

I'm not a Helm wizard myself so I like to have a second opinion from someone more educated

[eliaskoromilas]

Thanks for the comment @eliaskoromilas! I take that as a lgtm(?) (at least a weak signal smile).

yes, looks good :)

[marquiz]

OK, let's then merge this. Especially as it's not changing any default behavior
/lgtm