test/e2e: change node-specific config to a list #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Needs to be merged synchronously directly after kubernetes/test-infra#26724 |
k8s-ci-robot
added
the
do-not-merge/hold
|
kubernetes/test-infra#26724 is merged |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/test all |
Change the part of the e2e-test configuration that contains node-specific expected labels and annotations to a list, instead of a map. This makes the parsing order deterministic and makes it possible to e.g. have a default at the end of the list that captures "all the rest".
marquiz
force-pushed
the
devel/e2e-config-format
branch
from
c544781
to
380936e
Compare
|
/retitle test/e2e: change node-specific config to a list |
k8s-ci-robot
changed the title
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the part of the e2e-test configuration that contains
node-specific expected labels and annotations to a list, instead of a
map. This makes the parsing order deterministic and makes it possible to
e.g. have a default at the end of the list that captures "all the rest".