Revert type hack in api #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
approved
|
/retitle Revert type hack in api |
marquiz
force-pushed
the
devel/nfd-api-cleanup
branch
3 times, most recently
from
22cf9e2
to
4a667b0
Compare
|
#829 was merged -> |
k8s-ci-robot
removed
the
do-not-merge/hold
Update controller-gen and k8s code-generator to the latest releases.
Revert the hack that was a workaround for issues with k8s deepcopy-gen. New deepcopy-gen is able to generate code correctly without issues so this is not needed anymore. Also, removing this hack solves issues with object validation when creating NodeFeatureRules programmatically with nfd go-client. This is needed later with NodeFeatureRules e2e-tests. Logically reverts f3cc109.
marquiz
force-pushed
the
devel/nfd-api-cleanup
branch
from
4a667b0
to
38e763e
Compare
|
/assign @ArangoGutierrez |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ArangoGutierrez, marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert the hack that was a workaround for issues with k8s deepcopy-gen.
New deepcopy-gen is able to generate code correctly without issues so
this is not needed anymore.
Also, removing this hack solves issues with object validation when
creating NodeFeatureRules programmatically with nfd go-client. This is
needed later with NodeFeatureRules e2e-tests.
Update controller-gen and k8s code-generator to the latest releases.
Refresh auto-generated files
Depends on #829