-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tilt option for developing NFD #880
Add Tilt option for developing NFD #880
Conversation
Hi @fmuyassarov. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @marquiz |
Example snapshot of the web interface. Alternatively you can switch to by branch add-tiltfile/feruz and run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cools @fmuyassarov! Looks simple enough to start with. Just one minor comment
/ok-to-test
Signed-off-by: Feruzjon Muyassarov <feruzjon.muyassarov@intel.com>
c074080
to
6b0f6b6
Compare
Signed-off-by: Feruzjon Muyassarov <feruzjon.muyassarov@intel.com>
Signed-off-by: Feruzjon Muyassarov <feruzjon.muyassarov@intel.com>
6b0f6b6
to
a675fd9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, thanks a lot for this patch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ArangoGutierrez, fmuyassarov, marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Currently the way we develop and test the code is
This patch automates those steps via Tilt. It is an initial and simplified configuration and I expect to extend it in the future.
Fixes: #879