Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Netlify configuration file #895

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

fmuyassarov
Copy link
Member

This patch adds netlify configuration file which includes steps needed to build
the documentation as part of presubmit review process. I was planning to add
these commands from the web UI, but it is better to keep it here transparency
and the version control purposes.

Prerequisite for #886 and kubernetes/org#3665

This patch adds netlify configuration file which includes steps
needed to build the documentation as part of presubmit review
process.

Signed-off-by: Feruzjon Muyassarov <feruzjon.muyassarov@intel.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 15, 2022
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 15, 2022
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fmuyassarov! Looks simple enough to me. Haven't verified this myself but I trust you 😊

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmuyassarov, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2022
@fmuyassarov
Copy link
Member Author

Thanks @fmuyassarov! Looks simple enough to me. Haven't verified this myself but I trust you blush

Thanks, actually I forgot to mention that I have done prior test based on the config and example of deployed build is available here: https://632439999eada305e60df2e4--cozy-malabi-ecd098.netlify.app/get-started/index.html

@fmuyassarov
Copy link
Member Author

/cc @ArangoGutierrez

@fmuyassarov
Copy link
Member Author

/cc @zvonkok

@jjacobelli
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 27, 2022
@k8s-ci-robot k8s-ci-robot merged commit e3afe72 into kubernetes-sigs:master Sep 27, 2022
@fmuyassarov fmuyassarov deleted the add-netlify.toml branch September 27, 2022 07:50
@marquiz marquiz mentioned this pull request Dec 20, 2022
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants