-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apis/nfd: move annotation and label consts from nfd-master #904
apis/nfd: move annotation and label consts from nfd-master #904
Conversation
✅ Deploy Preview for kubernetes-sigs-nfd ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
8ec6dae
to
a9337ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is better 👍
/assign @ArangoGutierrez @zvonkok |
a9337ab
to
5ba9ef4
Compare
Move consts related to NFD annotations and labels from nfd-master to the api. Makes them more logically accessible for clients.
5ba9ef4
to
c1e6b41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ArangoGutierrez, fmuyassarov, marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Move consts related to NFD annotations and labels from nfd-master to the api. Makes them more logically accessible for clients.
Split out of #903