Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ephemeral environment for e2e test execution #917

Merged
merged 1 commit into from
Nov 2, 2022
Merged

add ephemeral environment for e2e test execution #917

merged 1 commit into from
Nov 2, 2022

Conversation

fmuyassarov
Copy link
Member

Partially fixes: #902

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 13, 2022
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 13, 2022
@netlify
Copy link

netlify bot commented Oct 13, 2022 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit 0118215
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/6362711b1a1bfe000863f147
😎 Deploy Preview https://deploy-preview-917--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@fmuyassarov fmuyassarov changed the title add ephemeral e2e test add ephemeral environment for e2e test execution Oct 13, 2022
marquiz
marquiz reviewed Oct 13, 2022
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! I think the patch to modify test/e2e/utils/pod.go would deserve a separate PR.

test/e2e/utils/pod.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 15, 2022
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 17, 2022
@fmuyassarov fmuyassarov mentioned this pull request Oct 17, 2022
Merged
@fmuyassarov fmuyassarov force-pushed the ephemeral-e2e branch 3 times, most recently from 5f32700 to f1e80ce Compare October 17, 2022 21:50
marquiz
marquiz reviewed Oct 18, 2022
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be a very nice improvement @fmuyassarov!

Some quick comments...

scripts/test-infra/test-e2e-presubmit.sh Outdated Show resolved Hide resolved
scripts/test-infra/test-e2e-presubmit.sh Outdated Show resolved Hide resolved
scripts/test-infra/test-e2e-presubmit.sh Outdated Show resolved Hide resolved
scripts/test-infra/test-e2e-presubmit.sh Outdated Show resolved Hide resolved
scripts/test-infra/test-e2e-presubmit.sh Outdated Show resolved Hide resolved
@fmuyassarov fmuyassarov marked this pull request as ready for review October 18, 2022 10:59
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 18, 2022
@fmuyassarov
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 2, 2022
@fmuyassarov
Add ephemeral E2E test environment
0118215 
This patch adds a script to run E2E test on kind ephemeral cluster
that gets deleted by the end of each test. Eventually, we will use
this script on pull requests as a presubmit test.

Signed-off-by: Feruzjon Muyassarov <feruzjon.muyassarov@intel.com>
@fmuyassarov
Copy link
Member Author

/hold cancel
@marquiz PTAL, thanks

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 2, 2022
marquiz
marquiz approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to go.

Note: as a future enhancement we might want to make this a bit lighter by building and testing only one image.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmuyassarov, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2022
@k8s-ci-robot k8s-ci-robot merged commit 34781af into kubernetes-sigs:master Nov 2, 2022
@fmuyassarov fmuyassarov mentioned this pull request Nov 2, 2022
Closed
4 tasks
@fmuyassarov fmuyassarov deleted the ephemeral-e2e branch November 2, 2022 18:32
@fmuyassarov fmuyassarov mentioned this pull request Nov 24, 2022
Merged
@marquiz marquiz mentioned this pull request Dec 20, 2022
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marquiz marquiz marquiz approved these changes

@ArangoGutierrez ArangoGutierrez Awaiting requested review from ArangoGutierrez

@jjacobelli jjacobelli Awaiting requested review from jjacobelli

@adrianchiris adrianchiris Awaiting requested review from adrianchiris

@zvonkok zvonkok Awaiting requested review from zvonkok

Assignees

@marquiz marquiz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

E2E infra migration
3 participants
@fmuyassarov @k8s-ci-robot @marquiz