Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/e2e: fix topologu-updater cmdline args #960

Merged
merged 1 commit into from
Nov 17, 2022

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Nov 17, 2022

The -kubelet-config-file flag got renamed to -kubelet-config-uri and the expected format changed from plain filepath to URI.

The -kubelet-config-file flag got renamed to -kubelet-config-uri and the
expected format changed from plain filepath to URI.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 17, 2022
@netlify
Copy link

netlify bot commented Nov 17, 2022

Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit a32ed5e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/63762150e4bbac0007081fe4
😎 Deploy Preview https://deploy-preview-960--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2022
@marquiz
Copy link
Contributor Author

marquiz commented Nov 17, 2022

/assign @fmuyassarov @Ethyling

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 17, 2022
@jjacobelli
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 17, 2022
Copy link
Contributor

@ffromani ffromani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
nit: typo in the commit title (topologu)
besides that I wonder why it didn't fail when the PR which changed the commandline was posted

@k8s-ci-robot k8s-ci-robot merged commit be8012e into kubernetes-sigs:master Nov 17, 2022
@marquiz
Copy link
Contributor Author

marquiz commented Nov 17, 2022

nit: typo in the commit title (topologu)

Woops, we missed that one 🙄

besides that I wonder why it didn't fail when the PR which changed the commandline was posted

That's because our e2e tests are run "after the fact". Not ideal, I know. But thanks to @fmuyassarov that's hopefully going to be addressed soon (kubernetes/test-infra#27755)

@marquiz marquiz deleted the fixes/e2e branch November 17, 2022 12:54
@marquiz marquiz mentioned this pull request Dec 20, 2022
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants