Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/e2e: add helper for creating new configmaps #965

Merged
merged 1 commit into from
Nov 24, 2022
Merged

test/e2e: add helper for creating new configmaps #965

merged 1 commit into from
Nov 24, 2022

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Nov 24, 2022

Implement a simple helper for creating a configmap with one key. One key (one config file) is enough for our current tests.

@marquiz
test/e2e: add helper for creating new configmaps
0174a64 
Implement a simple helper for creating a configmap with one key. One key
(one config file) is enough for our current tests.
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify
Copy link

netlify bot commented Nov 24, 2022 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit 0174a64
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/637f321318486600088a578a
😎 Deploy Preview https://deploy-preview-965--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 24, 2022
@marquiz
Copy link
Contributor Author

marquiz commented Nov 24, 2022

/assign @ArangoGutierrez @fmuyassarov

ping @Tal-or

fmuyassarov
fmuyassarov reviewed Nov 24, 2022
View reviewed changes
Copy link
Member

@fmuyassarov fmuyassarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @marquiz
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 24, 2022
@k8s-ci-robot k8s-ci-robot merged commit 7bab38a into kubernetes-sigs:master Nov 24, 2022
@marquiz marquiz deleted the devel/e2e-confifmap branch November 28, 2022 10:02
@marquiz marquiz mentioned this pull request Dec 20, 2022
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmuyassarov fmuyassarov fmuyassarov left review comments

@kad kad Awaiting requested review from kad

Assignees

@ArangoGutierrez ArangoGutierrez

@fmuyassarov fmuyassarov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marquiz @k8s-ci-robot @fmuyassarov @ArangoGutierrez