Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: simplify quick-start page #973

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Dec 1, 2022

Move topology-updater deployment notes to the topology-updater usage page. Also, rework the plaintext and headings a bit.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 1, 2022
@netlify
Copy link

netlify bot commented Dec 1, 2022

Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit 8a45384
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/63888080c844e40008d0e1e4
😎 Deploy Preview https://deploy-preview-973--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2022
@marquiz
Copy link
Contributor Author

marquiz commented Dec 1, 2022

/assign @ArangoGutierrez @fmuyassarov

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 1, 2022
@marquiz
Copy link
Contributor Author

marquiz commented Dec 1, 2022

ping @Tal-or @fromanirh touching the topology-updater documentation

Copy link
Contributor

@ffromani ffromani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
leaving the final ack to @Tal-or

Move topology-updater deployment notes to the topology-updater usage
page. Also, rework the plaintext and headings a bit.
@marquiz
Copy link
Contributor Author

marquiz commented Dec 1, 2022

Thanks @fromanirh

Rebased to resolved conflicts

Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 1, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit fbce8d7 into kubernetes-sigs:master Dec 1, 2022
@marquiz marquiz deleted the docs/quickstart branch December 1, 2022 14:16
@marquiz
Copy link
Contributor Author

marquiz commented Dec 1, 2022

@Tal-or this got merged a bit hastily but please see if you have any comments and I can address those

@Tal-or
Copy link
Contributor

Tal-or commented Dec 4, 2022

Thank you @marquiz it LGTM no additional changes are needed

@marquiz marquiz mentioned this pull request Dec 20, 2022
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants