nfd-topology-updater: update NodeResourceTopology objects directly

[marquiz]

Drop the gRPC communication to nfd-master and connect to the Kubernetes API server directly when updating NodeResourceTopology objects. Topology-updater already has connection to the API server for listing Pods so this is not that dramatic change. It also simplifies the code a lot as there is no need for the NFD gRPC client and no need for managing TLS certs/keys.

This change aligns nfd-topology-updater with the future direction of nfd-worker where the gRPC API is being dropped and replaced by a CRD-based API.

This patch also update deployment files and documentation to reflect this change.

TODO:: refactor the pkg/nfd-client package to pkg/nfd-worker nfd/tnfd-topology-updater but I think that can be made in a separate PR (and make reviewing easier).

[netlify]

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name	Link
🔨 Latest commit	f13ed2d
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/6391a86b5ea5dc0008570fa0
😎 Deploy Preview	https://deploy-preview-980--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[marquiz]

/assign @fmuyassarov @ArangoGutierrez
ping @Tal-or @fromanirh

[ffromani]

I will review the code ASAP. Designwise, I'm VERY much in favor of doing the changes directly from nfd-topology-updater instead of passing through nfd-master. I'm really happy this fits the design of NFD.

[marquiz]

I will review the code ASAP.

Thanks @fromanirh. Basically the code changes are moving code from nfd-master to topology-updater (plus simplifying it as we don't need much data conversions anymore), dropping NFD gRPC client bits from topology-updater and the dropping the NFD topology-updater gRPC api, plus then adjusting deployment, docs and tests to these changes.

On the TODO-list there is refactoring the pkg/nfd-client package to pkg/nfd-worker nfd/tnfd-opology-updater but I think that can be made in a separate PR (and make reviewing easier).

Designwise, I'm VERY much in favor of doing the changes directly from nfd-topology-updater instead of passing through nfd-master. I'm really happy this fits the design of NFD.

Yeah, we had the idea to have all K8s api comms in nfd-master. That was never the case for topology-updater and in retrospect that doesn't look that sensible 😊 It probably makes sense for Node objects but not for CRs.

[Tal-or]

A couple of notes from me.
In my opinion, this is a blessed change that simplifies the design.

[marquiz]

Thanks @Tal-or for the review. Review feedback responded/addressed.

[marquiz]

/retest

[Tal-or]

Thanks. LGTM
I'll leave the final approval to @fromanirh

[ArangoGutierrez]

PING @fromanirh
Looks good, but I prefer someone from the initial TopologyUpdater authors to have an eye here

[ffromani]

PING @fromanirh Looks good, but I prefer someone from the initial TopologyUpdater authors to have an eye here

sure thing, reviewing today December 6, 2022

[ffromani]

/lgtm
thanks!

[marquiz]

Rebased
ping @ArangoGutierrez

[fmuyassarov]

Looks good apart from minor comments in line.

[marquiz]

Thanks @fmuyassarov for the review. Comments addressed. PTAL.

[fmuyassarov]

I'm not an expert on this but code looks good to me and I see other folks happy with the change.
/lgtm