Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go.mod k8s.io to 1.26 #987

Merged
merged 2 commits into from
Dec 13, 2022
Merged

Conversation

fmuyassarov
Copy link
Member

Bump go.mod k8s.io to 1.26 and other dependencies upgrade.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 12, 2022
@netlify
Copy link

netlify bot commented Dec 12, 2022

Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit b296bdf
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/63985037df45c9000822b7d5
😎 Deploy Preview https://deploy-preview-987--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Dec 12, 2022
@fmuyassarov
Copy link
Member Author

/cc @marquiz @ArangoGutierrez

@marquiz
Copy link
Contributor

marquiz commented Dec 12, 2022

Thanks @fmuyassarov for the update!

It wasn't that easy, though 😅 E2e-tests cannot run because of some misalignment with the updated k8s e2e-test-framework

test/e2e/utils/pod/pod.go:114:4: f.PodClient undefined (type *framework.Framework has no field or method PodClient)
test/e2e/utils/pod/pod.go:114:55: undefined: framework.DefaultPodDeletionTimeout

@fmuyassarov
Copy link
Member Author

Thanks @fmuyassarov for the update!

It wasn't that easy, though sweat_smile E2e-tests cannot run because of some misalignment with the updated k8s e2e-test-framework

test/e2e/utils/pod/pod.go:114:4: f.PodClient undefined (type *framework.Framework has no field or method PodClient)
test/e2e/utils/pod/pod.go:114:55: undefined: framework.DefaultPodDeletionTimeout

Yup, I just got them fixed. There are quite some updates. Will push the changes in few mins

@fmuyassarov
Copy link
Member Author

I didn't notice those issues until I submitted the PR. Because usually I run make test, while those issues were caught by golanci-lint.

@marquiz
Copy link
Contributor

marquiz commented Dec 12, 2022

Still got some error

I1212 23:05:46.389382    1734 e2e.go:126] Starting e2e run "1d04aa90-691c-4ddd-b16e-41da0d23ca2c" on Ginkgo node 1
Invalid Function
ginkgo.AfterEach("Node Feature Discovery topology updater CRD and RBAC removal", func(f *framework.Framework, failed bool) {
/home/marquiz/go/git/node-feature-discovery/review/test/e2e/topology_updater.go:103
  [AfterEach] node must be passed func(), func(ctx SpecContext), or func(ctx
  context.Context).
  You passed func(*framework.Framework, bool) instead.

  Learn more at: http://onsi.github.io/ginkgo/#node-decorators-overview

@fmuyassarov
Copy link
Member Author

Thanks for catching those e2e issues @marquiz . PTAL.

go.mod Outdated Show resolved Hide resolved
Signed-off-by: Feruzjon Muyassarov <feruzjon.muyassarov@intel.com>
Signed-off-by: Feruzjon Muyassarov <feruzjon.muyassarov@intel.com>
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmuyassarov, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2022
@k8s-ci-robot k8s-ci-robot merged commit 6975680 into kubernetes-sigs:master Dec 13, 2022
@fmuyassarov fmuyassarov deleted the bump-k8s branch December 13, 2022 10:53
This was referenced Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants