-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump go.mod k8s.io to 1.26 #987
Conversation
✅ Deploy Preview for kubernetes-sigs-nfd ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Thanks @fmuyassarov for the update! It wasn't that easy, though 😅 E2e-tests cannot run because of some misalignment with the updated k8s e2e-test-framework
|
Yup, I just got them fixed. There are quite some updates. Will push the changes in few mins |
I didn't notice those issues until I submitted the PR. Because usually I run make test, while those issues were caught by golanci-lint. |
f1a0738
to
5bdee4b
Compare
Still got some error
|
5bdee4b
to
6a86168
Compare
Thanks for catching those e2e issues @marquiz . PTAL. |
Signed-off-by: Feruzjon Muyassarov <feruzjon.muyassarov@intel.com>
Signed-off-by: Feruzjon Muyassarov <feruzjon.muyassarov@intel.com>
6a86168
to
b296bdf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fmuyassarov, marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Bump go.mod k8s.io to 1.26 and other dependencies upgrade.