-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test/e2e: fix creation of NFD CRDs #993
Conversation
✅ Deploy Preview for kubernetes-sigs-nfd ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @fmuyassarov @ArangoGutierrez |
After introducing NodeFeatureRule we packed two CRD definitions in one yaml file. Our e2e-tests were not prepared to that and the file itself was also renamed so it couldn't even be read by the test suite. With this change the e2e-tests start to create NodeFeatre CRD in the test cluster, preparing for the addition of e2e-tests for NodeFeature API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 168902aca8dfe587269609546035ddf13626b678
|
After introducing NodeFeatureRule we packed two CRD definitions in one yaml file. Our e2e-tests were not prepared to that and the file itself was also renamed so it couldn't even be read by the test suite.
With this change the e2e-tests start to create NodeFeatre CRD in the test cluster, preparing for the addition of e2e-tests for NodeFeature API.