Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E: default seccompProfile to runtimeDefault for nfd worker #995

Merged

Conversation

fmuyassarov
Copy link
Member

@fmuyassarov fmuyassarov commented Dec 14, 2022

Use RuntimeDefault seccomp profile in nfd worker and topology updater pod spec similar to nfd master.
Otherwise, we get PodSecurity violation when running locally:

  Dec 14 16:45:41.440: Unexpected error:
      <*errors.StatusError | 0xc000d58a00>: {
          ErrStatus: {
              TypeMeta: {Kind: "", APIVersion: ""},
              ListMeta: {
                  SelfLink: "",
                  ResourceVersion: "",
                  Continue: "",
                  RemainingItemCount: nil,
              },
              Status: "Failure",
              Message: "pods \"nfd-worker-6ee0652e-2dca-49a0-ac88-9896453b3655\" is forbidden: violates PodSecurity \"restricted:latest\": restricted volume types (volumes \"host-boot\", \"host-os-release\", \"host-sys\", \"host-usr-lib\", \"host-usr-src\" use restricted volume type \"hostPath\"), seccompProfile (pod or container \"node-feature-discovery\" must set securityContext.seccompProfile.type to \"RuntimeDefault\" or \"Localhost\")",
              Reason: "Forbidden",
              Details: {
                  Name: "nfd-worker-6ee0652e-2dca-49a0-ac88-9896453b3655",
                  Group: "",
                  Kind: "pods",
                  UID: "",
                  Causes: nil,
                  RetryAfterSeconds: 0,
              },
              Code: 403,
          },
      }
      pods "nfd-worker-6ee0652e-2dca-49a0-ac88-9896453b3655" is forbidden: violates PodSecurity "restricted:latest": restricted volume types (volumes "host-boot", "host-os-release", "host-sys", "host-usr-lib", "host-usr-src" use restricted volume type "hostPath"), seccompProfile (pod or container "node-feature-discovery" must set securityContext.seccompProfile.type to "RuntimeDefault" or "Localhost")
  occurred

Use RuntimeDefault seccomp profile in nfd worker and topology
updater pod spec similar to nfd master.

Signed-off-by: Feruzjon Muyassarov <feruzjon.muyassarov@intel.com>
@netlify
Copy link

netlify bot commented Dec 14, 2022

Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit ae8ba01
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/6399e66da82d760008ebc52d
😎 Deploy Preview https://deploy-preview-995--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 14, 2022
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 14, 2022
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fmuyassarov!
/lgtm

@fmuyassarov
Copy link
Member Author

/test pull-node-feature-discovery-build-image-cross-generic

@fmuyassarov
Copy link
Member Author

@marquiz for some reason lgtm and approve labels are not set. Would you mind to re-add them?

Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 14, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmuyassarov, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: bbec5b9626994bac9ff86863a56fb597ecfc4de3

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2022
@k8s-ci-robot k8s-ci-robot merged commit 323fd5c into kubernetes-sigs:master Dec 14, 2022
@marquiz marquiz mentioned this pull request Dec 20, 2022
22 tasks
@fmuyassarov fmuyassarov deleted the seccomp-profile-nfd-worker branch January 2, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants